Closed
Conversation
djdiskmachine
approved these changes
Jul 29, 2024
Owner
djdiskmachine
left a comment
djdiskmachine
left a comment
There was a problem hiding this comment.
This is great, thanks to you an nine-h for submitting!
Owner
|
I'm getting the following issue when building for DEB: |
Author
|
I'll close this one as the changes are now in #95 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a set of improvements to the Makefile that @Nine-H put together, I separated them out because I was working from that branch when I started work on the SDL2 changes and I think this is a good starting point for merging the X64 and SDL2 support.
Its marked as a draft because I haven't tested it yet but I figure its ready for feedback from anyone.