Skip to content

launcher: print build info at startup#252

Merged
icex2 merged 3 commits intodjhackersdev:masterfrom
shizmob:feature/launcher-version
Jun 25, 2023
Merged

launcher: print build info at startup#252
icex2 merged 3 commits intodjhackersdev:masterfrom
shizmob:feature/launcher-version

Conversation

@shizmob
Copy link
Copy Markdown
Contributor

@shizmob shizmob commented May 1, 2023

Following the same pattern as inject and some hooks, useful for when getting debug logs.

One worry I have, same as when used elsewhere, is that version.c doesn't get rebuilt every build, allowing it to become stale. Does the Makefile system allow specifying a force-rebuild target?

@icex2
Copy link
Copy Markdown
Contributor

icex2 commented May 1, 2023

One worry I have, same as when used elsewhere, is that version.c doesn't get rebuilt every build, allowing it to become stale. Does the Makefile system allow specifying a force-rebuild target?

Not that I am aware of. The current way to do this is running clean builds whenever something gets actually distributed. So taking builds from our CI pipelines are fine, for local dev builds, you have to manually run a clean build. Not great, but the important stuff (official bin releases) works for now.

@shizmob shizmob force-pushed the feature/launcher-version branch from 8c53e7b to 5f414c6 Compare May 1, 2023 14:29
@shizmob
Copy link
Copy Markdown
Contributor Author

shizmob commented May 1, 2023

In that case, I just added that functionality. :)

@shizmob shizmob force-pushed the feature/launcher-version branch from 5f414c6 to e0d75ce Compare May 1, 2023 14:32
@icex2 icex2 merged commit d3f1929 into djhackersdev:master Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants