bootstrap.xml parsing and handling #254
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icex2
reviewed
May 1, 2023
| /* Read command line */ | ||
|
|
||
| options_init(&options); | ||
| options_read_early_cmdline(&options, argc, argv); |
Contributor
There was a problem hiding this comment.
Might be good to have reasoning in the commit why this is required.
icex2
reviewed
May 1, 2023
icex2
reviewed
May 1, 2023
icex2
reviewed
May 1, 2023
|
|
||
| #include "imports/avs.h" | ||
|
|
||
| struct bootstrap_startup_config { |
Contributor
There was a problem hiding this comment.
Is this unified across all different games? Anything that only came with specific (newer/older) versions of bootstrap?
Contributor
Author
There was a problem hiding this comment.
A bunch of things came only with newer versions, that's why almost all psmap properties are _OPTIONAL with a sensible default.
Contributor
There was a problem hiding this comment.
Defaults match with official bootstrap? If yes, that might be worth a comment in the code.
Contributor
|
Closing as I picked up the work and continue driving it from a new PR: #272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patchset adds full support for parsing and handling of
prop/bootstrap.xmlas alternative to the command-line parameter configuration of launcher itself.It adds the following command line options:
-C: path to bootstrap.xml (default:prop/bootstrap.xml)-Z: selector in bootstrap.xml to use. Required for bootstrap.xml parsing to take place.If given a valid bootstrap.xml and selector, launcher will:
avs-config.xmlpath from it by defaultea3-config.xmlpath from it by defaultapp-config.xmlAs indicated by the
@573ordinal number, allavs_fs_*imports need to be checked, except for AVS 2.15.8.This MR depends on #253 for its added property definitions.