Fix : memory leak caused by DotNetEventListener class #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cribed to avoid memory leak.
| } | ||
|
|
||
| EnableEventSources(collector); | ||
| EventSourceCreated += OnEventSourceCreated; |
There was a problem hiding this comment.
Probably simply overriding EventListener.OnEventSourceCreated method could be simpler, you will not have to be bothered about unsubscribing at all.
djluck
approved these changes
Jan 30, 2020
Owner
djluck
left a comment
djluck
left a comment
There was a problem hiding this comment.
Thanks for your contribution- looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Event that is subscribed to EventSourceCreated should be unsubscribed to avoid memory leak.