Multi-target Support #79
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added a Sites folder from which you can get the settings for any new target * Set up a target for Udemy which would compile a version specific for Udemy * Changed the name of ViewController to WSViewController to match source code * Cleaned up code a bit
* Separate app icon for each target * Menu customizations based on app title * Removed hardcoded application window size and position and set it to be saved based on last values
* Added a WSBaseSettings class to allow having all the default settings there with the ability to override for each target via a sub-class * Added a WSBaseSettings sub-class named Settings as a singleton so that it can be accessed easily from anywhere - also providing for future features
* Added ability to remember the last location in the app and go back to it on re-launch
* Enabled automatic code signing
* Renamed WSMediaKeysSupport.swift to WSApplication.swift and changed the name of the underlying class as well to be consistent * Fixed needing to specify the module/target name for the NSPrincipalClass in each copy of Info.plist
* Reorganized code into folders * Added a separate icon for menu bar * Removed separate view for popup and re-used the one from the main app * Fixed a couple of typos in Credits.rtf * Renamed Info.plist files as per target and moved those to the project root * Removed unused code files
0xWDG
approved these changes
Jan 4, 2018
Collaborator
|
Thanks, I will run some testing and then merge it. |
0xWDG
approved these changes
Jan 4, 2018
0xWDG
reviewed
Jan 4, 2018
| var fake = true | ||
|
|
||
| // The URL to start with - the last page you were on or the base URL | ||
| func startURL() -> String { |
Collaborator
There was a problem hiding this comment.
This needs to be a setting, so users can enable/disable them.
Collaborator
There was a problem hiding this comment.
I will fix this in a separate pull request.
0xWDG
approved these changes
Jan 4, 2018
0xWDG
approved these changes
Jan 4, 2018
0xWDG
approved these changes
Jan 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, instead of creating a new version of the repo for each site, you can simply add a new target and add the target specific files (just a copy of Settings and Info.plist) to the Sites sub-folder and compile the app. This way, you can maintain multiple apps for different sites in the same codebase.