make setup more friendly to newcomers#17
Merged
dka23 merged 2 commits intodka23:masterfrom Jan 29, 2017
Merged
Conversation
for easier setup, testing, and rapid deployment could be improved by having mvn dependencies pre-downloaded before CMD and only downloading when mvn dependencies change since last docker image cache
newcomers potentially several hours on setup (ask me how i know)
Owner
|
Hi Mike, thanks for this pull request. You're completely right - I'm also using this in production for a long time and have not had problems with it... Cheers |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main points:
Docker is easier to setup, test, and deploy with most of the time. Recommending we provide a
Dockerfileas an alternate route to save time and effort for those who know.Not sure why the
README.mdstates:...but this seems inaccurate. Work hasn't progressed in over 14 months. Its been tested by multiple people, and it works for me, at least. Recommending we remove the note. It seems like a stable beta, if not a release.
The wording in the setup instructions was at times inaccurate or vague concerning labels, and largely assumed the reader was intimately familiar with the chosen stack and subject matter (Maven, Spring, JIRA, GitHub [Enterprise] API, GitLab Administration, etc.). In my case I'm more of a system administrator than a fan of any technology involved here; my customers are proponents of JIRA, and I am a proponent of GitLab, so not all of the instructions weren't obvious to me at first glance.
Overall, thanks for this! I have a feeling it will become more popular if it were just more obvious a) that it does work, and b) how easy it is to set up.