Skip to content

add controller buttons to settings.toml#4830

Merged
Loobinex merged 2 commits into
dkfans:masterfrom
PieterVdc:controller_settings
May 24, 2026
Merged

add controller buttons to settings.toml#4830
Loobinex merged 2 commits into
dkfans:masterfrom
PieterVdc:controller_settings

Conversation

@PieterVdc
Copy link
Copy Markdown
Member

No description provided.

Copilot AI review requested due to automatic review settings May 24, 2026 12:19
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the settings TOML serialization/deserialization to support controller button bindings alongside existing keyboard keycodes/modifiers, enabling controller mappings to be stored in settings.toml.

Changes:

  • Added controller button name↔bitmask mapping table.
  • Added parsing/formatting helpers for controller_buttons string values.
  • Updated load_settings() / save_settings() to read/write controller_buttons per game key.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/config_settings.c Outdated
Comment thread src/config_settings.c
Comment thread src/config_settings.c
@PieterVdc PieterVdc marked this pull request as draft May 24, 2026 12:30
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@PieterVdc PieterVdc marked this pull request as ready for review May 24, 2026 14:41
@Loobinex Loobinex merged commit bc29e75 into dkfans:master May 24, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants