Skip to content

Bump node version to 24#238

Merged
dkhalife merged 1 commit intomainfrom
bump_node
Mar 8, 2026
Merged

Bump node version to 24#238
dkhalife merged 1 commit intomainfrom
bump_node

Conversation

@dkhalife
Copy link
Owner

@dkhalife dkhalife commented Mar 8, 2026

No description provided.

Copilot AI review requested due to automatic review settings March 8, 2026 22:22
@dkhalife dkhalife merged commit 3616382 into main Mar 8, 2026
7 checks passed
@dkhalife dkhalife deleted the bump_node branch March 8, 2026 22:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates GitHub Actions workflows to run the frontend build/release steps on a newer Node.js major version.

Changes:

  • Bump full-release.yml Node.js setup from 22.x to 24.x.
  • Simplify frontend-build.yml by removing the Node version matrix and pinning CI to Node 24.x.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
.github/workflows/full-release.yml Updates the Node.js version used when building the frontend as part of the release workflow.
.github/workflows/frontend-build.yml Pins frontend CI to Node 24.x and removes the multi-version test matrix.

Comment on lines +22 to +25
- name: Use Node.js 24.x
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version: 24.x
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This workflow previously tested the frontend on multiple supported Node versions (20.x, 22.x). By hardcoding 24.x and removing the matrix, CI no longer validates the documented “NodeJS 20+” support (README.md:174), which can let Node-20 regressions slip through. Consider restoring a version matrix (at least 20.x + the new target), or update the documented supported Node range if Node 24-only is intended.

See below for a potential fix:

    strategy:
      matrix:
        node-version: [20.x, 24.x]

    steps:
    - uses: actions/checkout@v4
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v4
      with:
        node-version: ${{ matrix.node-version }}

Copilot uses AI. Check for mistakes.
Comment on lines +23 to +26
- name: Use Node.js 24.x
uses: actions/setup-node@v4
with:
node-version: 22.x
node-version: 24.x
Copy link

Copilot AI Mar 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reproducible releases, consider aligning all workflows that run Yarn/Node with the same explicit Node version. cut-release.yml runs yarn version but does not use actions/setup-node, so it will use whatever Node version happens to be preinstalled on ubuntu-latest, which can drift independently from this 24.x bump.

See below for a potential fix:

      - name: Use Node.js 22.x
        uses: actions/setup-node@v4
        with:
          node-version: 22.x

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants