Conversation
There was a problem hiding this comment.
Pull request overview
Updates GitHub Actions workflows to run the frontend build/release steps on a newer Node.js major version.
Changes:
- Bump
full-release.ymlNode.js setup from 22.x to 24.x. - Simplify
frontend-build.ymlby removing the Node version matrix and pinning CI to Node 24.x.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/full-release.yml |
Updates the Node.js version used when building the frontend as part of the release workflow. |
.github/workflows/frontend-build.yml |
Pins frontend CI to Node 24.x and removes the multi-version test matrix. |
| - name: Use Node.js 24.x | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: ${{ matrix.node-version }} | ||
| node-version: 24.x |
There was a problem hiding this comment.
This workflow previously tested the frontend on multiple supported Node versions (20.x, 22.x). By hardcoding 24.x and removing the matrix, CI no longer validates the documented “NodeJS 20+” support (README.md:174), which can let Node-20 regressions slip through. Consider restoring a version matrix (at least 20.x + the new target), or update the documented supported Node range if Node 24-only is intended.
See below for a potential fix:
strategy:
matrix:
node-version: [20.x, 24.x]
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
| - name: Use Node.js 24.x | ||
| uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 22.x | ||
| node-version: 24.x |
There was a problem hiding this comment.
For reproducible releases, consider aligning all workflows that run Yarn/Node with the same explicit Node version. cut-release.yml runs yarn version but does not use actions/setup-node, so it will use whatever Node version happens to be preinstalled on ubuntu-latest, which can drift independently from this 24.x bump.
See below for a potential fix:
- name: Use Node.js 22.x
uses: actions/setup-node@v4
with:
node-version: 22.x
No description provided.