Support mariadb 12 and sqlite migrations properly#243
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the API server’s database migrations to better support SQLite and MySQL/MariaDB (incl. MariaDB 12) by using dialect-specific DDL for schema creation and indexes.
Changes:
- Make the initial schema migration dialect-aware (SQLite vs MySQL/MariaDB) for column types, auto-increment, and index creation syntax.
- Update the Entra auth migration to create a partial unique index on SQLite and a generated-column-backed unique index on MySQL/MariaDB; add rollback cleanup for the generated columns.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apiserver/internal/migrations/001_initial_schema.go | Adds dialect branching for initial DDL (types/auto-inc) and avoids unsupported CREATE INDEX IF NOT EXISTS on MySQL. |
| apiserver/internal/migrations/002_entra_auth.go | Changes unique index creation strategy for MySQL/MariaDB (generated columns) and cleans those columns up on Down(). |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.