Skip to content

Nan handling #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 2, 2025
Merged

Nan handling #368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c7d966a
hide NaN results
dkhunt27 Oct 2, 2025
921acbf
handle nan
dkhunt27 Oct 2, 2025
fcdcea1
bundled
dkhunt27 Oct 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions dist/index.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/index.js.map
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"name": "nx-code-coverage",
"name": "action-nx-code-coverage",
"version": "0.0.0",
"description": "Github action for combining/compiling code coverage from an nx monorepo",
"main": "lib/index.js",
Expand All @@ -17,7 +17,7 @@
},
"repository": {
"type": "git",
"url": "git+https://github.com/dkhunt27/nx-code-coverage.git"
"url": "git+https://github.com/dkhunt27/action-nx-code-coverage.git"
},
"keywords": [
"actions",
Expand Down
6 changes: 4 additions & 2 deletions src/comment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,8 @@ export const buildComment = ({
if (
result.diff !== undefined &&
result.diff !== null &&
(result.diff as unknown) !== 'Unknown'
(result.diff as unknown) !== 'Unknown' &&
!Number.isNaN(result.diff)
) {
if (result.diff < 0) {
arrow = '▾'
Expand All @@ -48,7 +49,8 @@ export const buildComment = ({
if (
result.coverage === undefined ||
result.coverage === null ||
(result.coverage as unknown) === 'Unknown'
(result.coverage as unknown) === 'Unknown' ||
Number.isNaN(result.coverage)
) {
coverage = 'unknown'
} else {
Expand Down
Loading