fix(installer): correct hashtable access for checksum hash #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Get-FileHashCompat function returns a hashtable with a Hash key, but Test-Checksum was calling .ToLower() on the hashtable itself instead of the hash string. Changed $hash.ToLower() to $hash.Hash.ToLower().
dkmnx
added a commit
that referenced
this pull request
Jan 30, 2026
- Update coverage metrics: cmd package at 53.4%, overall at 79.5% - Document why original 70% target was not achievable - Add comprehensive analysis of coverage gaps and integration test coverage - Add resolution summary showing all high/medium priority issues RESOLVED - Document new tests: cmd/audit_helpers_test.go (343 lines, 6 functions) High and medium priority security issues (#1, #2, #3, #4, #5, #10) are now RESOLVED.
dkmnx
added a commit
that referenced
this pull request
Feb 9, 2026
fix(installer): correct hashtable access for checksum hash
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Get-FileHashCompat function returns a hashtable with a Hash key, but Test-Checksum was calling .ToLower() on the hashtable itself instead of the hash string. Changed $hash.ToLower() to $hash.Hash.ToLower().