Stop sanity check from resetting module_compressed_suffix.#112
Merged
GoPerry merged 1 commit intodkms-project:masterfrom Dec 3, 2019
Merged
Stop sanity check from resetting module_compressed_suffix.#112GoPerry merged 1 commit intodkms-project:masterfrom
GoPerry merged 1 commit intodkms-project:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When installing a kernel that uses
MODULE_COMPRESS_XZfrom a kernel that usesMODULE_COMPRESS_GZIP, DKMS almost works. It builds the modules, keeps them in/var/lib/dkms, and mistakenly believes that it has successfully copied them into the target kernel's tree (which makes attempts to diagnose withdkms statusor to rebuild withdkms installconfusing, to say the least). Long night on this one.The problem is that right before the installation,
check_version_sanityruns. It fails to pass the intended kernel version toset_module_suffix, causing it to analyze the tree foruname -rand forget the compression suffix for the kernel we're trying to use. Let's fix that.This PR works for now, but may want to consider removing the default parameter from
set_module_suffixentirely to make sure this type of thing can't slip under the rug again.