Enable using add, build and install with a directory again#178
Merged
scaronni merged 1 commit intodkms-project:masterfrom Nov 17, 2021
Merged
Conversation
Since commit e73f9bb ("dkms: fixup add/remove...uninstall permission checking"), it was no longer possible to use "dkms add" with a directory: $ dkms add test/dkms_test-1.0 Error! Arguments <module> and <module-version> are not specified. Usage: add <module>/<module-version> or add -m <module>/<module-version> or add -m <module> -v <module-version> But when options -m and -v are given, the source directory is ignored. Fix this issue by removing the check for -m and -v in add, build and install actions. This makes the following commands work again (for example on Arch Linux): $ dkms add test/dkms_test-1.0 Creating symlink /var/lib/dkms/dkms_test/1.0/source -> /usr/src/dkms_test-1.0 $ dkms remove -m dkms_test -v 1.0 --all ... $ dkms install -k 5.15.2-arch1-1 test/dkms_test-1.0 Creating symlink /var/lib/dkms/dkms_test/1.0/source -> /usr/src/dkms_test-1.0 Building module: cleaning build area... make -j8 KERNELRELEASE=5.15.2-arch1-1 -C /lib/modules/5.15.2-arch1-1/build M=/var/lib/dkms/dkms_test/1.0/build... cleaning build area... dkms_test.ko: Running module version sanity check. - Original module - No original module exists within this kernel - Installation - Installing to /lib/modules/5.15.2-arch1-1/kernel/extra/ depmod... $ dkms remove -m dkms_test -v 1.0 --all ... $ dkms build -k 5.15.2-arch1-1 test/dkms_test-1.0 Creating symlink /var/lib/dkms/dkms_test/1.0/source -> /usr/src/dkms_test-1.0 Building module: cleaning build area... make -j8 KERNELRELEASE=5.15.2-arch1-1 -C /lib/modules/5.15.2-arch1-1/build M=/var/lib/dkms/dkms_test/1.0/build... cleaning build area... Fixes: dkms-project#177
fishilico
added a commit
to fishilico/chipsec
that referenced
this pull request
Nov 17, 2021
DKMS 3.0 broke `dkms add drivers/linux` (cf. chipsec#1305 (comment)). This was fixed upstream in dkms-project/dkms#178. While waiting for a new DKMS release which would be applied by Arch Linux maintainers, it is possible to work around the issue by removing some checks from the `dkms` script. Add a `sed` command which does that. Signed-off-by: Nicolas Iooss <nicolas.iooss_git@polytechnique.org>
npmitche
pushed a commit
to chipsec/chipsec
that referenced
this pull request
Nov 17, 2021
DKMS 3.0 broke `dkms add drivers/linux` (cf. #1305 (comment)). This was fixed upstream in dkms-project/dkms#178. While waiting for a new DKMS release which would be applied by Arch Linux maintainers, it is possible to work around the issue by removing some checks from the `dkms` script. Add a `sed` command which does that. Signed-off-by: Nicolas Iooss <nicolas.iooss_git@polytechnique.org>
BrentHoltsclaw
pushed a commit
to BrentHoltsclaw/chipsec
that referenced
this pull request
Nov 24, 2021
DKMS 3.0 broke `dkms add drivers/linux` (cf. chipsec#1305 (comment)). This was fixed upstream in dkms-project/dkms#178. While waiting for a new DKMS release which would be applied by Arch Linux maintainers, it is possible to work around the issue by removing some checks from the `dkms` script. Add a `sed` command which does that. Signed-off-by: Nicolas Iooss <nicolas.iooss_git@polytechnique.org>
BrentHoltsclaw
pushed a commit
to BrentHoltsclaw/chipsec
that referenced
this pull request
Dec 2, 2021
DKMS 3.0 broke `dkms add drivers/linux` (cf. chipsec#1305 (comment)). This was fixed upstream in dkms-project/dkms#178. While waiting for a new DKMS release which would be applied by Arch Linux maintainers, it is possible to work around the issue by removing some checks from the `dkms` script. Add a `sed` command which does that. Signed-off-by: Nicolas Iooss <nicolas.iooss_git@polytechnique.org>
npmitche
pushed a commit
to chipsec/chipsec
that referenced
this pull request
Dec 3, 2021
DKMS 3.0 broke `dkms add drivers/linux` (cf. #1305 (comment)). This was fixed upstream in dkms-project/dkms#178. While waiting for a new DKMS release which would be applied by Arch Linux maintainers, it is possible to work around the issue by removing some checks from the `dkms` script. Add a `sed` command which does that. Signed-off-by: Nicolas Iooss <nicolas.iooss_git@polytechnique.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since commit e73f9bb ("dkms: fixup add/remove...uninstall permission checking"), it was no longer possible to use "dkms add" with a directory:
But when options
-mand-vare given, the source directory is ignored.Fix this issue by removing the check for
-mand-vinadd,buildandinstallactions. This makes the following commands work again (for example on Arch Linux):Fixes: #177