Fix source only tarballs unpacked with ldtarball#189
Merged
scaronni merged 1 commit intodkms-project:masterfrom Dec 13, 2021
Merged
Fix source only tarballs unpacked with ldtarball#189scaronni merged 1 commit intodkms-project:masterfrom
scaronni merged 1 commit intodkms-project:masterfrom
Conversation
When the tarball is created with
dkms mktarball -m dkms_test -v 1.0 --archive test.tar --source-only
The tarball has the form
dkms_main_tree/
dkms_source_tree/dkms.conf
dkms_source_tree/dkms_test.c
dkms_source_tree/Makefile
In the loop over the locations
for loc in dkms_source_tree dkms_binaries_only ''; do
The first loc is successful.
The second fails with
Error! No valid dkms.conf in dkms_source_tree or dkms_binaries_only.
A break is needed to catch the first success.
Suggested-by: Jan Edler <jan.edler@indexengines.com>
Signed-off-by: Tom Rix <trix@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the tarball is created with
dkms mktarball -m dkms_test -v 1.0 --archive test.tar --source-only
The tarball has the form
dkms_main_tree/
dkms_source_tree/dkms.conf
dkms_source_tree/dkms_test.c
dkms_source_tree/Makefile
In the loop over the locations
The first loc is successful.
The second fails with
Error! No valid dkms.conf in dkms_source_tree or dkms_binaries_only.
A break is needed to catch the first success.
Suggested-by: Jan Edler jan.edler@indexengines.com
Signed-off-by: Tom Rix trix@redhat.com