Put version comparison before info comparison#227
Merged
scaronni merged 1 commit intodkms-project:masterfrom Jun 24, 2022
Merged
Put version comparison before info comparison#227scaronni merged 1 commit intodkms-project:masterfrom
scaronni merged 1 commit intodkms-project:masterfrom
Conversation
The priority of version comparison should be higher than the priority of module content comparison. Sometimes when we need to fix some bugfixes, there may be no difference when comparing module content, resulting in dkms not being able to be installed and still keeping the drivers in the original system. If we compare the versions first, and if the version is higher than the driver version in the current system, we replace it and then can solve this problem. Signed-off-by: Meng Tang <tangmeng@uniontech.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The priority of version comparison should be higher than
the priority of module content comparison. Sometimes when
we need to fix some bugfixes, there may be no difference
when comparing module content, resulting in dkms not being
able to be installed and still keeping the drivers in the
original system. If we compare the versions first, and if the
version is higher than the driver version in the current system,
we replace it and then can solve this problem.
Signed-off-by: Meng Tang tangmeng@uniontech.com