Look for sign-file regardless#230
Merged
scaronni merged 2 commits intodkms-project:masterfrom Jul 15, 2022
Merged
Conversation
|
Couple of comments to make it more robust, but globally this is a good fix, and it fixed my local install, so thanks! 🙏 |
1ace
approved these changes
Jul 3, 2022
Use bash internal test to avoid a fork, and replace the string check for a executable check. We also don't need to set do_signing to 0
Contributor
Author
Thanks for your review, and you are welcome. |
|
I have suggested a configuration change for Arch in the downstream bug report https://bugs.archlinux.org/task/75212. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #229