Skip to content

Follow the target kernel's module hash algorithm#274

Merged
evelikov merged 1 commit intodkms-project:masterfrom
xuzhen:hash
Nov 4, 2022
Merged

Follow the target kernel's module hash algorithm#274
evelikov merged 1 commit intodkms-project:masterfrom
xuzhen:hash

Conversation

@xuzhen
Copy link
Collaborator

@xuzhen xuzhen commented Oct 28, 2022

Fixes #266

@xuzhen xuzhen force-pushed the hash branch 2 times, most recently from 062d4af to 2d25346 Compare October 28, 2022 03:43
@xuzhen xuzhen force-pushed the hash branch 4 times, most recently from e86eeba to 494110a Compare October 29, 2022 02:17
@evelikov evelikov merged commit 81ae9d1 into dkms-project:master Nov 4, 2022
@mavoga
Copy link

mavoga commented Nov 5, 2022

I would have preferred

sign_hash="$(grep "^CONFIG_MODULE_SIG_HASH=" "${kernel_config}" | cut -d= -f2 | tr -d '"')"

or even

eval " $(grep "^CONFIG_MODULE_SIG_HASH=" "${kernel_config}")"
sign_hash="${CONFIG_MODULE_SIG_HASH:-sha512}"
unset CONFIG_MODULE_SIG_HASH

My 2 cents

@evelikov
Copy link
Collaborator

evelikov commented Nov 5, 2022

@mavoga I'm open for the former, but I would avoid eval unless strictly needed. PRs welcome o/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sha512 signed modules not works

3 participants