dkms: always use read_conf_or_die#354
Merged
scaronni merged 1 commit intodkms-project:masterfrom Oct 21, 2023
Merged
Conversation
Currently dkms status and by extension dkms autoinstall use read_conf, which prints an error yet results in the commands succeeding. Browsing across Arch and Debian, this can only happen on user error. As such lets flip it to the fatal "_or_die" variant, like all the other instances in the codebase. Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently dkms status and by extension dkms autoinstall use read_conf, which prints an error yet results in the commands succeeding.
Browsing across Arch and Debian, this can only happen on user error. As such lets flip it to the fatal "_or_die" variant, like all the other instances in the codebase.
See #352 for context.
/cc @scaronni @anbe42 @C0rn3j do shout if you think this is a bad idea, thanks in advance.