dkms: use saner compression defaults#390
Merged
evelikov merged 1 commit intodkms-project:masterfrom Jan 31, 2024
Merged
Conversation
This was referenced Jan 29, 2024
Collaborator
Author
Currently our compression options vary from those used in upstream kernel. As of 6.8-rc2 upstream uses (ignoring force/rm input file etc): - gzip -9 - xz --check=crc32 --lzma2=dict=1MiB Note: some older kernels lacked crc32 and/or used 2MiB - zstd -T0 (aka -3) With the higher dictionary size (xz) and compression size (20+ zstd) more memory is required for decompression. Which may be a problem if the kernel itself is responsible for the decompression (instead of kmod), since it uses a smaller/limited ram amount. Reduce the numbers of be compatible with upstream. Closes: dkms-project#386 Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
evelikov
force-pushed
the
align-compression
branch
from
445c8a4 to
cda4025
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently our compression options vary from those used in upstream kernel. As of 6.8-rc2 upstream uses (ignoring force/rm input file etc):
With the higher dictionary size (xz) and compression size (20+ zstd) more memory is required for decompression. Which may be a problem if the kernel itself is responsible for the decompression (instead of kmod), since it uses a smaller/limited ram amount.
Reduce the numbers of be compatible with upstream.
Closes: #386
@anbe42