Allow running MOK generation as a command#424
Merged
Conversation
evelikov
reviewed
Jul 5, 2024
cc2482d to
0270ab2
Compare
Member
Author
zeroepoch
approved these changes
Aug 12, 2024
Collaborator
zeroepoch
left a comment
There was a problem hiding this comment.
I'm a relatively new reviewer to the DKMS project so I'm not aware of the full scope of changes required to add this new feature (if something was overlooked and missing), but the changes proposed in this MR look reasonable and not introducing any obvious bugs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow calling part of
prepare_signingas a standalone function to generate the MOK key as a standalone command.This is for the use case described here: https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/2034#note_2147952
This is the minimal change to get the command available. Open to suggestions if we should instead rework the whole signing logic.