Skip to content

Allow running MOK generation as a command#424

Merged
scaronni merged 1 commit intomasterfrom
sb-keys-command
Aug 18, 2024
Merged

Allow running MOK generation as a command#424
scaronni merged 1 commit intomasterfrom
sb-keys-command

Conversation

@scaronni
Copy link
Member

Allow calling part of prepare_signing as a standalone function to generate the MOK key as a standalone command.

This is for the use case described here: https://gitlab.gnome.org/GNOME/gnome-software/-/merge_requests/2034#note_2147952

$ sudo dkms generate_mok
Signing key: /var/lib/dkms/mok.key
Public certificate (MOK): /var/lib/dkms/mok.pub

This is the minimal change to get the command available. Open to suggestions if we should instead rework the whole signing logic.

@scaronni scaronni requested a review from evelikov June 25, 2024 07:57
@scaronni scaronni changed the title Allow running mok generation as a command Allow running MOK generation as a command Jun 25, 2024
@scaronni scaronni force-pushed the sb-keys-command branch 2 times, most recently from cc2482d to 0270ab2 Compare July 7, 2024 12:44
@scaronni scaronni requested a review from xuzhen July 14, 2024 08:04
@scaronni
Copy link
Member Author

@evelikov or @xuzhen any chance for a review and merge?

@scaronni scaronni requested review from evelikov and zeroepoch August 6, 2024 08:03
Copy link
Collaborator

@zeroepoch zeroepoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a relatively new reviewer to the DKMS project so I'm not aware of the full scope of changes required to add this new feature (if something was overlooked and missing), but the changes proposed in this MR look reasonable and not introducing any obvious bugs.

@scaronni scaronni merged commit 33c47ac into master Aug 18, 2024
@scaronni scaronni deleted the sb-keys-command branch August 18, 2024 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants