Conversation
373b6a1 to
d103953
Compare
8dbaa75 to
4c0919d
Compare
b225503 to
f1b9d01
Compare
zeroepoch
approved these changes
Sep 9, 2024
Member
Author
|
Thanks for the review! |
e326f92 to
15e598d
Compare
evelikov
requested changes
Sep 9, 2024
Collaborator
evelikov
left a comment
There was a problem hiding this comment.
Greetings, I have emerged from the woodwork - sorry for dropping off the radar.
Can we split off /etc/sysconfig in separate commit please - I could swear I've saw some distro use it.
Member
Author
Sure, ok. |
Member
Author
|
|
evelikov
approved these changes
Sep 11, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second out of output refining. Example with autoinstall and multiple modules, before:
Most of the
autoinstalloutput is useless and not well placed. Also the depmod line should be attached to the "Installng [..]" output and separated from the "Sign [..]" output.After changing the output, it's structured like this, with each block separated by context:
After spending lot of time trying to figure out why the output trapped by the tests is slightly different on old Alpine containers and the old Ubuntu VM that was used for the test, I narrowed it down to the
invoke_commandcombined withstdbuf. Funny thing is that if you run the commands directly on the containers the output is consistent, and does not exhibit the extra blank line before "Cleaning build area".To avoid this issue entirely, in
generalize_expected_outputremove all blank lines, so the output is trapped 100% the same on all containers.