sleep in a single background process while waiting for command to complete#444
Merged
scaronni merged 8 commits intodkms-project:masterfrom Sep 20, 2024
hkskoglund:invoke_command_fix
Merged
sleep in a single background process while waiting for command to complete#444scaronni merged 8 commits intodkms-project:masterfrom hkskoglund:invoke_command_fix
scaronni merged 8 commits intodkms-project:masterfrom
hkskoglund:invoke_command_fix
Conversation
… into invoke_command_fix
Member
|
Hi @hkskoglund, that's interesting. I guess this is the same issue I was getting when trying to change the output, so in the end I removed the printing of the progressing dots in the tests: https://github.com/dell/dkms/blob/master/.github/workflows/tests.yml#L95-L98 I'm guessing if we should remove the entire progressing dots thing instead of trying to fix it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! The current invoke_command creates new sleep background processes for each single . printed. This fix only sleeps in 1 background process, so there should be a slight performance improvement. The main command to be executed now runs in the foreground. I had some issues with 4 dots getting printed which caused ./run_test.sh to fail, so I disabled printing . for packages matching dkms*_test.