Allow patches, scripts and overrides in /etc/dkms#583
Open
scaronni wants to merge 1 commit intodkms-project:mainfrom
Open
Allow patches, scripts and overrides in /etc/dkms#583scaronni wants to merge 1 commit intodkms-project:mainfrom
scaronni wants to merge 1 commit intodkms-project:mainfrom
Conversation
Member
Author
|
@cyqsimon can I get some feedback? To test: |
zeroepoch
approved these changes
Mar 14, 2026
| run_with_expected_output dkms install -k "${KERNEL_VER}" -m dkms_patches_test -v 1.0 << EOF | ||
| ${SIGNING_PROLOGUE} | ||
| Applying patch patch1.patch... done. | ||
| Applying patch subdir/patch2.patch... done. |
Collaborator
There was a problem hiding this comment.
I'm assuming /etc/dkms/<module>/patches/subdir/patch2.patch overrides the system subdir/patch2.patch? Meaning the subdir is also respected and checked? I wonder if the test should be reversed? Seems like more of a nitpick though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #562.
Overrides in
/etc/dkms:PATCH[#]directives, can now:/etc/dkms/<module>/patches//etc/dkms/<module>/patches/POST_ADD,PRE_BUILD,POST_BUILD,PRE_INSTALL,POST_INSTALLandPOST_REMOVEcan now:/etc/dkms/<module>//etc/dkms/<module>/Examples
Overriding a patch
Original:
Override:
New local patch
Adding a new local patch that survives across DKMS module upgrades:
New post script
Adding a new post script that survives across DKMS module upgrades: