Skip to content

fix: Respect disabled sorting animations everywhere#148

Merged
dkorecko merged 1 commit intomainfrom
fix/respect-no-sorting-animations-everywhere
Oct 4, 2025
Merged

fix: Respect disabled sorting animations everywhere#148
dkorecko merged 1 commit intomainfrom
fix/respect-no-sorting-animations-everywhere

Conversation

@dkorecko
Copy link
Copy Markdown
Owner

@dkorecko dkorecko commented Oct 4, 2025

Summary by CodeRabbit

  • New Features
    • Added a board-level setting to enable or disable drag-and-drop animations.
    • Column reordering in Board View now respects this setting, providing instant moves when animations are disabled and smooth transitions when enabled.
    • Subtask reordering in the Edit Card modal also honors this preference, improving performance and reducing motion for users sensitive to animations.

@dkorecko dkorecko merged commit 80e8b09 into main Oct 4, 2025
3 of 4 checks passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Oct 4, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Introduces a conditional Animation parameter to SortableList instances in two Razor components. In EditCardModal.razor, the Animation value is set to 0 when _card.Column.Board.DisableSortingAnimations is true, otherwise 200, affecting subtask sorting visuals. In BoardView.razor, the Animation value is set to 0 when _board.DisableSortingAnimations is true, otherwise 200, affecting column reordering visuals. No changes to move logic, data updates, or public/exported entities are indicated.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/respect-no-sorting-animations-everywhere

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: ASSERTIVE

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between 37638eb and 3dca141.

📒 Files selected for processing (2)
  • Ticky.Web/Components/Dialogs/EditCardModal.razor (1 hunks)
  • Ticky.Web/Components/Pages/BoardView.razor (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dkorecko dkorecko deleted the fix/respect-no-sorting-animations-everywhere branch October 4, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant