Skip to content

Major PR#3

Merged
dkoyro merged 9 commits into
masterfrom
PR-DEV
Jan 11, 2019
Merged

Major PR#3
dkoyro merged 9 commits into
masterfrom
PR-DEV

Conversation

@dkoyro

@dkoyro dkoyro commented Jan 10, 2019

Copy link
Copy Markdown
Owner

Major PR

@dkoyro

dkoyro commented Jan 10, 2019

Copy link
Copy Markdown
Owner Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dkoyro

If they are not already assigned, you can assign the PR to them by writing /assign @dkoyro in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkoyro dkoyro added the size/L label Jan 10, 2019
@dkoyro

dkoyro commented Jan 10, 2019

Copy link
Copy Markdown
Owner Author

⭐ PR built and available in a preview environment dkoyro-jxtest-pr-3 here

@dkoyro

dkoyro commented Jan 11, 2019

Copy link
Copy Markdown
Owner Author

/lgtm

@dkoyro

dkoyro commented Jan 11, 2019

Copy link
Copy Markdown
Owner Author

@dkoyro: you cannot LGTM your own PR.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dkoyro

dkoyro commented Jan 11, 2019

Copy link
Copy Markdown
Owner Author

/approve

@dkoyro dkoyro merged commit edf7bbe into master Jan 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant