Skip to content

approvers/reviewers#4

Merged
dkoyro merged 1 commit into
masterfrom
PR-DEV
Jan 16, 2019
Merged

approvers/reviewers#4
dkoyro merged 1 commit into
masterfrom
PR-DEV

Conversation

@dkoyro

@dkoyro dkoyro commented Jan 14, 2019

Copy link
Copy Markdown
Owner

No description provided.

@dkoyro dkoyro added the size/S label Jan 14, 2019
@dkoyro

dkoyro commented Jan 14, 2019

Copy link
Copy Markdown
Owner Author

⭐ PR built and available in a preview environment dkoyro-jxtest-pr-4 here

@dkoyro

dkoyro commented Jan 16, 2019

Copy link
Copy Markdown
Owner Author

/assign okoyro

@dkoyro

dkoyro commented Jan 16, 2019

Copy link
Copy Markdown
Owner Author

@dkoyro: GitHub didn't allow me to assign the following users: okoyro.

Note that only dkoyro members and repo collaborators can be assigned.
For more information please see the contributor guide

Details

In response to this:

/assign okoyro

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@okoyro

okoyro commented Jan 16, 2019

Copy link
Copy Markdown

/approve

1 similar comment
@dkoyro

dkoyro commented Jan 16, 2019

Copy link
Copy Markdown
Owner Author

/approve

@okoyro

okoyro commented Jan 16, 2019

Copy link
Copy Markdown

/assign @dkoyro

@dkoyro dkoyro self-assigned this Jan 16, 2019
@dkoyro

dkoyro commented Jan 16, 2019

Copy link
Copy Markdown
Owner Author

/approve

@okoyro

okoyro commented Jan 16, 2019

Copy link
Copy Markdown

/lgtm

@dkoyro

dkoyro commented Jan 16, 2019

Copy link
Copy Markdown
Owner Author

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: okoyro
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: dkoyro

If they are not already assigned, you can assign the PR to them by writing /assign @dkoyro in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dkoyro

dkoyro commented Jan 16, 2019

Copy link
Copy Markdown
Owner Author

@okoyro: changing LGTM is restricted to assignees, and only dkoyro/jxtest repo collaborators may be assigned issues.

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dkoyro dkoyro assigned dkoyro and unassigned dkoyro Jan 16, 2019
@dkoyro dkoyro merged commit 2d834d3 into master Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants