Skip to content

Fix authentication credential propagation and implement separate secrets architecture #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkrizic merged 6 commits into from
Jan 26, 2026
Merged

Fix authentication credential propagation and implement separate secrets architecture #52

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4d6e058
Initial plan
Copilot Jan 26, 2026
c7bb97e
Fix authentication variable names and secret mounting
Copilot Jan 26, 2026
eab0031
Complete authentication fixes - all tests passing
Copilot Jan 26, 2026
9855a0f
Add build artifacts to .gitignore
Copilot Jan 26, 2026
9fe8c18
Create separate secrets for CLI and service with shared password
Copilot Jan 26, 2026
0e2964a
Change CLI to use simpler env var names (USERNAME/PASSWORD)
Copilot Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,5 @@
.idea/
# Build artifacts
cli/cli
ui/ui
service/service
3 changes: 0 additions & 3 deletions charts/feature/templates/cli-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,4 @@ data:
ENDPOINT: {{ default (printf "%s:%v" (include "feature.fullname" .) .Values.service.service.port) .Values.cli.endpoint | quote }}
OPENTELEMETRY_ENABLED: {{ ternary "true" "false" .Values.cli.opentelemetry.enabled | quote }}
OPENTELEMETRY_ENDPOINT: {{ .Values.cli.opentelemetry.endpoint | quote }}
{{- if .Values.service.authentication.enabled }}
USERNAME: {{ .Values.service.authentication.username | quote }}
{{- end }}
{{- end }}
2 changes: 1 addition & 1 deletion charts/feature/templates/cli-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ spec:
name: {{ include "feature.cli.fullname" . }}
{{- if .Values.service.authentication.enabled }}
- secretRef:
name: {{ printf "%s-auth" (include "feature.fullname" .) }}
name: {{ printf "%s-cli-auth" (include "feature.fullname" .) }}
{{- end }}
{{- with .Values.cli.resources }}
resources:
Expand Down
25 changes: 25 additions & 0 deletions charts/feature/templates/cli-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
{{- if and .Values.cli.enabled .Values.service.authentication.enabled }}
{{- $secretName := printf "%s-cli-auth" (include "feature.fullname" .) }}
{{- $existingSecret := lookup "v1" "Secret" .Release.Namespace $secretName }}
apiVersion: v1
kind: Secret
metadata:
name: {{ $secretName }}
labels:
{{- include "feature.labels" . | nindent 4 }}
app.kubernetes.io/component: cli
type: Opaque
data:
{{- $password := .Values.service.authentication.password }}
{{- if and $existingSecret $existingSecret.data (index $existingSecret.data "PASSWORD") }}
{{- /* Preserve existing password on upgrades */ -}}
PASSWORD: {{ index $existingSecret.data "PASSWORD" | quote }}
{{- else }}
{{- /* Generate new password only on first install or when explicitly set */ -}}
{{- if eq $password "" }}
{{- $password = randAlphaNum 24 }}
{{- end }}
PASSWORD: {{ $password | b64enc | quote }}
{{- end }}
USERNAME: {{ .Values.service.authentication.username | b64enc | quote }}
{{- end }}
3 changes: 2 additions & 1 deletion charts/feature/templates/service-secret.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ metadata:
type: Opaque
data:
{{- $password := .Values.service.authentication.password }}
{{- if and $existingSecret $existingSecret.data }}
{{- if and $existingSecret $existingSecret.data (index $existingSecret.data "AUTHENTICATION_PASSWORD") }}
{{- /* Preserve existing password on upgrades */ -}}
AUTHENTICATION_PASSWORD: {{ index $existingSecret.data "AUTHENTICATION_PASSWORD" | quote }}
{{- else }}
Expand All @@ -21,4 +21,5 @@ data:
{{- end }}
AUTHENTICATION_PASSWORD: {{ $password | b64enc | quote }}
{{- end }}
AUTHENTICATION_USERNAME: {{ .Values.service.authentication.username | b64enc | quote }}
{{- end }}
3 changes: 3 additions & 0 deletions charts/feature/templates/ui-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,7 @@ data:
SUBPATH: {{ .Values.ui.subpath | quote }}
OPENTELEMETRY_ENABLED: {{ ternary "true" "false" .Values.cli.opentelemetry.enabled | quote }}
OPENTELEMETRY_ENDPOINT: {{ .Values.cli.opentelemetry.endpoint | quote }}
{{- if .Values.service.authentication.enabled }}
AUTHENTICATION_ENABLED: "true"
{{- end }}
{{- end }}