Skip to content
This repository was archived by the owner on Apr 20, 2024. It is now read-only.

refactor: Refactor Config class#46

Merged
dkvc merged 3 commits intomainfrom
refactor-config
Mar 31, 2023
Merged

refactor: Refactor Config class#46
dkvc merged 3 commits intomainfrom
refactor-config

Conversation

@dkvc
Copy link
Copy Markdown
Owner

@dkvc dkvc commented Mar 31, 2023

No description provided.

dkvc added 3 commits March 31, 2023 11:40
1. Config class no longer asks for user input.
2. Value of `cache_time` is randomized between 52 and 65 minutes.
3. `user_input()` and `overwrite()` methods are deprecated.
4. `check()` method no longer creates new file if its return value is
False.
5. Remove redundant logging info.
6. `set_info()` signature is changed to `main()`.
7. Most fields and methods have default access modfiier.
8. Getters are deprecated since fields have default access modifier.
1. `main()` is used instead of `set_info()`.
2. Value of `cache_time` is randomized between 52 and 65 minutes.
@dkvc dkvc self-assigned this Mar 31, 2023
@dkvc dkvc added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request labels Mar 31, 2023
@dkvc dkvc linked an issue Mar 31, 2023 that may be closed by this pull request
@dkvc dkvc merged commit 56d6d55 into main Mar 31, 2023
@dkvc dkvc deleted the refactor-config branch March 31, 2023 11:48
@dkvc dkvc restored the refactor-config branch March 31, 2023 11:50
@dkvc dkvc deleted the refactor-config branch March 31, 2023 11:53
@dkvc dkvc restored the refactor-config branch March 31, 2023 11:57
@dkvc dkvc deleted the refactor-config branch March 31, 2023 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant