Update ERC7947 interface #154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Hrom131
commented
Aug 11, 2025
Hrom131
commented
- Since this PR suggests a bug fix, the tests have been added and the coverage is 100%.
- Since this PR introduces a new feature, the update has been discussed in an Issue or with the team.
- This PR is just a minor change, like a typo fix.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #154 +/- ##
=========================================
Coverage ? 99.94%
=========================================
Files ? 49
Lines ? 3401
Branches ? 402
=========================================
Hits ? 3399
Misses ? 2
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Arvolear
added a commit
that referenced
this pull request
Aug 15, 2025
* added bitcoin libs * renamed BitcoinHelper to EndianConverter * refactored natspec * review fixes coverage 100% * BtcTxParser -> TxParser * updated readme * refactored tests for txParser * fixed parseBlockHeader LE numbers * refactored endianConverter * added bytes to bytes conversion in EndianConverter * cleaned headers data for tests * review fixes * package json fix * refactored parseCuint in TxParser * refactored naming in EndianConverter * natspec EndianConverter * removed convertion function from bytes to uint and vice versa * covereage for EndianConverter * refactored _reverseUint128 in EndianConverter * fixed pragma solidity * Update ERC7947 interface (#154) * Update ERC7947 interface * Fix unit tests * typo * added check for insertion attack in TxMerkleProof; added isBitcoinTransaction and parseCuintMemory to TxParser * utilized addHexPrefix * TxMerkleProof now uses txIndex to calculate hashing directions * fixed typo * consistency in codestyle * updated version to 3.2.0 * removed unused test case * removed excess comment * fixed natspec * refactored helpers * added reference for insertion attack * update readme --------- Co-authored-by: Oleh Komendant <44612825+Hrom131@users.noreply.github.com> Co-authored-by: Artem Chystiakov <artem.ch31@gmail.com>
Arvolear
added a commit
that referenced
this pull request
Aug 15, 2025
* Added bitcoin libs (#153) * added bitcoin libs * renamed BitcoinHelper to EndianConverter * refactored natspec * review fixes coverage 100% * BtcTxParser -> TxParser * updated readme * refactored tests for txParser * fixed parseBlockHeader LE numbers * refactored endianConverter * added bytes to bytes conversion in EndianConverter * cleaned headers data for tests * review fixes * package json fix * refactored parseCuint in TxParser * refactored naming in EndianConverter * natspec EndianConverter * removed convertion function from bytes to uint and vice versa * covereage for EndianConverter * refactored _reverseUint128 in EndianConverter * fixed pragma solidity * Update ERC7947 interface (#154) * Update ERC7947 interface * Fix unit tests * typo * added check for insertion attack in TxMerkleProof; added isBitcoinTransaction and parseCuintMemory to TxParser * utilized addHexPrefix * TxMerkleProof now uses txIndex to calculate hashing directions * fixed typo * consistency in codestyle * updated version to 3.2.0 * removed unused test case * removed excess comment * fixed natspec * refactored helpers * added reference for insertion attack * update readme --------- Co-authored-by: Oleh Komendant <44612825+Hrom131@users.noreply.github.com> Co-authored-by: Artem Chystiakov <artem.ch31@gmail.com> * remove some contracts * removed compilation for pragma solidity 0.7.6 * removed bignumber.js from dependencies * Update AAccountRecovery contract * update changelog, revert version --------- Co-authored-by: Yuliia Aritkulova <94910987+aritkulova@users.noreply.github.com> Co-authored-by: Oleh Komendant <44612825+Hrom131@users.noreply.github.com> Co-authored-by: Oleh Komendant <oleg02kom@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.