Skip to content

relax taggedalgebraic dependency#46

Merged
s-ludwig merged 1 commit intodlang-community:masterfrom
John-Colvin:patch-1
Aug 31, 2019
Merged

relax taggedalgebraic dependency#46
s-ludwig merged 1 commit intodlang-community:masterfrom
John-Colvin:patch-1

Conversation

@John-Colvin
Copy link
Copy Markdown
Contributor

it's a real pain otherwise due to dependency clashes.

@joseph-wakeling-frequenz
Copy link
Copy Markdown
Contributor

Hah, is it that simple? I thought there had been some breaking changes which needed more intrusive version-specific changes.

@John-Colvin
Copy link
Copy Markdown
Contributor Author

John-Colvin commented Aug 30, 2019

Well, I don't really know, but the tests pass ¯\(ツ)

Hoping that someone who does know a bit better chooses whether to merge this or not.

@s-ludwig
Copy link
Copy Markdown
Collaborator

Should be fine, the breaking changes should be limited to rarely encountered corner cases. BTW, it may even make sense to require 0.11.x at some point and make use of TaggedUnion and This, which would make the code a bit prettier.

@s-ludwig s-ludwig merged commit 3de7bd3 into dlang-community:master Aug 31, 2019
@John-Colvin
Copy link
Copy Markdown
Contributor Author

Of course, to really get the benefit of this change, a new release here would be necessary.

@John-Colvin
Copy link
Copy Markdown
Contributor Author

ping, still need a new release to get people to be able to use this

@joseph-wakeling-frequenz
Copy link
Copy Markdown
Contributor

@John-Colvin

Well, I don't really know, but the tests pass ¯(ツ)/¯

Apologies for the late feedback -- I think the issues I was seeing may have been about compiler version rather than taggedalgebraic version. I'll submit a CI PR shortly that may illustrate the issue.

@joseph-wakeling-frequenz
Copy link
Copy Markdown
Contributor

Oh wait, it's worse than that. CI is still testing with taggedalgebraic v0.10.9, because of the fixed dub.selections.json. So it's never actually validating that v0.11.x works.

Going by my own local testing we have a double bind here:

  • taggedalgebraic v0.11.x works with the compilers used in current CI

  • it will fail with DMD >= 2.086

That's what I saw in my own local testing when I first filed #44, which is why I didn't follow up quickly at the time.

@joseph-wakeling-frequenz
Copy link
Copy Markdown
Contributor

In short, please do NOT create a new release until these issues are resolved (I've written up details in #44). Otherwise there will be a lot of unhappy users of std_data_json ;-)

@John-Colvin John-Colvin deleted the patch-1 branch January 6, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants