Skip to content

Conversation

@alphaKAI
Copy link
Contributor

I added GNEX Ltd. into organizations

@PetarKirov
Copy link
Member

Since list is sorted alphabetically, can you move GNEX between Funkwerk and Infognition? Otherwise, the change looks good to me.

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, you can test your changes by going to CyberShadow/DAutoTest -> Details -> web/orgs-using-d.html New.

orgs-using-d.dd Outdated
Digital Marketing Solutions Company.,
$(LINK_ROW
$(FA_GITHUB gnexltd) $(FA_SEPARATOR)
$(FA_HIRING https://globalnet-ex.com/employment/engineer)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove https://, otherwise, the link doesn't work, because of how ddoc handles :.

@alphaKAI
Copy link
Contributor Author

Thx, i've fixed order of list, and removed https://, then i re-pushed

Copy link
Member

@PetarKirov PetarKirov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing my feedback, now all looks good to me. The latest preview can be seen here:
http://dtest.thecybershadow.net/artifact/website-be9ac379a06ac636456fd156e9ffc87c39011769-5c248514a0fda1158ab4f481c9ca1ed4/web/orgs-using-d.html

@alphaKAI
Copy link
Contributor Author

alphaKAI commented Feb 2, 2017

@ZombineDev Cool! Can you review to merge this PR?
GitHub says merging is blocked because there is no approved review.

@PetarKirov
Copy link
Member

Unfortunately, I can't merge this, because I don't have rights.
Ping @CyberShadow @MartinNowak @JackStouffer.

@PetarKirov
Copy link
Member

BTW, can you squash your two commits into one? Individual commits are good for review, but when the code is ready to be merged it is better to squash fix-up commits that don't have add value to the history of the repository.
http://gitready.com/advanced/2009/02/10/squashing-commits-with-rebase.html

@alphaKAI
Copy link
Contributor Author

alphaKAI commented Feb 2, 2017

@ZombineDev I integrated two commits into one with given URL by you.

@PetarKirov
Copy link
Member

Thanks, saying from experience, your PR should be merged in a couple of days max.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot. I added a minified version of your logo, s.t. requests are faster.

@wilzbach wilzbach merged commit db1c287 into dlang:master Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants