-
-
Notifications
You must be signed in to change notification settings - Fork 382
add gnex into orgs #1562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add gnex into orgs #1562
Conversation
|
Since list is sorted alphabetically, can you move GNEX between Funkwerk and Infognition? Otherwise, the change looks good to me. |
PetarKirov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, you can test your changes by going to CyberShadow/DAutoTest -> Details -> web/orgs-using-d.html New.
orgs-using-d.dd
Outdated
| Digital Marketing Solutions Company., | ||
| $(LINK_ROW | ||
| $(FA_GITHUB gnexltd) $(FA_SEPARATOR) | ||
| $(FA_HIRING https://globalnet-ex.com/employment/engineer) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to remove https://, otherwise, the link doesn't work, because of how ddoc handles :.
|
Thx, i've fixed order of list, and removed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing my feedback, now all looks good to me. The latest preview can be seen here:
http://dtest.thecybershadow.net/artifact/website-be9ac379a06ac636456fd156e9ffc87c39011769-5c248514a0fda1158ab4f481c9ca1ed4/web/orgs-using-d.html
|
@ZombineDev Cool! Can you review to merge this PR? |
|
Unfortunately, I can't merge this, because I don't have rights. |
|
BTW, can you squash your two commits into one? Individual commits are good for review, but when the code is ready to be merged it is better to squash fix-up commits that don't have add value to the history of the repository. |
6d550b8 to
ce2d55a
Compare
|
@ZombineDev I integrated two commits into one with given URL by you. |
|
Thanks, saying from experience, your PR should be merged in a couple of days max. |
ce2d55a to
9bcdcac
Compare
wilzbach
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot. I added a minified version of your logo, s.t. requests are faster.
I added GNEX Ltd. into organizations