Fixed issues in C code examples and added modern C standard idioms (C99 & C11). #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
reviewed
Feb 6, 2017
ctod.dd
Outdated
| $(P C doesn't directly support assert, but does support __FILE__ | ||
| and __LINE__ from which an assert macro can be built. In fact, | ||
| there appears to be practically no other use for __FILE__ and __LINE__.) | ||
| $(P C doesn't directly support assert in the language, but does define a |
schlupa
force-pushed
the
patch-1
branch
2 times, most recently
from
1a29aa1 to
d64fbba
Compare
schlupa
force-pushed
the
patch-1
branch
2 times, most recently
from
d5bc5e3 to
a3cfd34
Compare
… & C11). The C examples used in that file are not purely C and contain several C++ ism. Furthermore, they do not use C99 idioms that are now very common. Some of the examples also contain errors. - typecasts of allocation functions are typical of C++ code but are errors in pure C. - names with leading underscore are reserved for the implementation and shall not be used. - One example freed an unitialized pointer -> crash guaranteed. - Where appropriate, modified or extended the C examples with constructs from C99 and C11. Mainly designated initializers.
Confusing formulation amended.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small changes in the "Programming in D for C Programmers" page.