Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Mar 2, 2017

Why is this important?

An updated copyright that is older than X years shows that a file hasn't been maintained properly and the trust of the user sink immediately if he reads that the file was touched for the last time ten years ago.
For most Phobos modules the copyright is never updated as this is regarded as unnecessary churn and/or because different copyright year formats are used.

For an impression, a couple of randomly selected modules:

Why the D Language Foundation?

  • The footer is inserted by the owner of the website and documentation which is the D Language Foundation. The author header at the beginning of each module, which is a lot more visible than the tiny foooter still shows all authors of a file (that the "Authors" there don't reflect the actual list of Authors is a different topic for another discussion)
  • This is free advertisement for D and its foundation
  • Boost only requires us to include the full Boost header in all source files, which btw we mostly don't do:

The copyright notices in the Software and this entire statement, including
the above license grant, this restriction and the following disclaimer,
must be included in all copies of the Software, in whole or in part, and
all derivative works of the Software, unless such copies or derivative
works are solely in the form of machine-executable object code generated by
a source language processor.

http://www.boost.org/LICENSE_1_0.txt

Examples from other Languages

dlang.org.ddoc Outdated
http://digitalmars.com
Copyright (c) 1999-$(YEAR) by the D Language Foundation
All Rights Reserved.
http://dlang.org/foundation.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use https

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing @WalterBright is OK with what essentially indicates a copyright assignment and transfer of ownership to the D foundation :)

| http://digitalmars.com
| Copyright (c) 1999-$#{year} by the D Language Foundation
| All Rights Reserved.
| http://dlang.org/foundation.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

block copyright
| | Page generated by <a href="https://github.com/rejectedsoftware/ddox">ddox</a>.
#copyright.smallprint
| Copyright &copy; 1999-2017 by the <a href="#{root_dir}/foundation.html">D Language Foundation</a> | Page generated by <a href="https://github.com/rejectedsoftware/ddox">ddox</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

year is hardcoded here, can you use $#{year}?

ebook.ddoc Outdated
http://www.digitalmars.com
Copyright (c) 1999-$(YEAR) by the D Language Foundation
All Rights Reserved.
http://dlang.org/foundation.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https

@wilzbach wilzbach force-pushed the copyright-foundation branch from 57c4079 to 15e2be1 Compare March 2, 2017 17:14
@wilzbach
Copy link
Contributor Author

wilzbach commented Mar 2, 2017

I'm guessing @WalterBright is OK with what essentially indicates a copyright assignment and transfer of ownership to the D foundation :)

Sorry this time I did a rebase, so the comment from @CyberShadow got lost.
@andralex or @WalterBright could you quickly confirm this?

@andralex
Copy link
Member

andralex commented Mar 2, 2017

This should be fine, if @WalterBright wants to amend things we can always change it back.

@wilzbach
Copy link
Contributor Author

wilzbach commented Mar 2, 2017

This should be fine, if @WalterBright wants to amend things we can always change it back.

Awesome! As I fixed the nits, I am adding "auto-merge" now :)

dlang.org.ddoc Outdated

CONSOLE=$(TC pre, console notranslate, $0)
COPYRIGHT=Copyright &copy; 1999-$(YEAR) by the $(LINK2 $(ROOT)/foundation.html, D Language Foundation)
COPYRIGHT_FOUNDATION=Copyright &copy; 1999-$(YEAR) by the $(LINK2 $(ROOT)/foundation.html, D Language Foundation)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Meh apparently it's better to use ROOT_DIR without the leading /

@wilzbach
Copy link
Contributor Author

wilzbach commented Mar 2, 2017

FYI @CyberShadow it seems that for dlang.org the bot still can't merge "auto-merge" PRs.
It's a bit hard to debug without much logging output.

However, maybe it simply doesn't receive a hook event?

@CyberShadow
Copy link
Member

This repository has 2 webhooks, while Phobos has 8. So... maybe? :)

One of those on Phobos but not here is https://dlang-bot.herokuapp.com/github_hook

@MartinNowak

@wilzbach
Copy link
Contributor Author

wilzbach commented Mar 2, 2017

One of those on Phobos but not here is https://dlang-bot.herokuapp.com/github_hook

Yep that's the one :)

@wilzbach wilzbach merged commit 83430bb into dlang:master Mar 2, 2017
@wilzbach wilzbach deleted the copyright-foundation branch March 2, 2017 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants