Skip to content

Conversation

@MartinNowak
Copy link
Member

@CyberShadow
Copy link
Member

Typo in commit message, verbatiom

@MartinNowak
Copy link
Member Author

In fact this seems to solve all problems w/ changelog gen nicely, once there is a checked-in _pre.dd file, the changed tool will no longer be invoked, allowing us to "freeze" the changelog. One a version is out, we'll bump VERSION and have changelog previews again.
A bit too complex for my taste, but should work.

@MartinNowak MartinNowak changed the title prefer creating changelog verbatiom from _pre.dd prefer creating changelog verbatim from _pre.dd Mar 28, 2017
@MartinNowak
Copy link
Member Author

Typo in commit message, verbatiom

thx, fixed :)

@MartinNowak
Copy link
Member Author

I still have an issue w/ the doc gen for ddmd_mars.html, b/c it imports ddmd.objc which fails to compile on non-OSX machines. The hacky default is to abuse D's module != filename mechanism and pass ddmd/objc_stub.d to the compiler, so that it'll import that one instead of ddmd/objc.d :/.

Just wondering why that doesn't happen with Digger.

@MartinNowak
Copy link
Member Author

Just wondering why that doesn't happen with Digger.

Because of -O -release -inline, the release uses RELEASE=1 to enable optimizations.

@CyberShadow CyberShadow merged commit a82624a into dlang:stable Mar 28, 2017
@MartinNowak MartinNowak deleted the fix_doc_build branch March 28, 2017 16:09
@MartinNowak
Copy link
Member Author

There are 2 long-term conflicts between dlang.org's Makefile and the release build script, since dlang.org turned into it's own build-the-world system.

One recurring problem is that dlang.org always tries to build sth. that's already taken care of the other build system. While it sounds simple to refactor the makefile in such a way to have a dlang.org only target, it's fairly tricky due make's nature of declaring dependencies and build targets.

order-only prerequisites work to some extend but seem somewhat fragile (at least noone thinks of using them).

The other problem is that the release build needs to use the pre-release targets (and only those) to builds a release documentation. At the time the docs are build, no binaries/tags are published, so we can't use the normal release target.
I hope this will become less tricky with the switch to dpl-docs, but to get rid of the dlang.org patch in the release script we'd need to introduce a third target I guess.

@MartinNowak MartinNowak restored the fix_doc_build branch March 28, 2017 16:21
@MartinNowak MartinNowak deleted the fix_doc_build branch March 28, 2017 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants