Add labels to spec/lex.dd #1674
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
PetarKirov
approved these changes
Jun 7, 2017
Contributor
Author
|
CC @CyberShadow - anything blocking this? It just adds labels to the headings ... |
CyberShadow
approved these changes
Jun 13, 2017
CyberShadow
reviewed
Jun 13, 2017
spec/lex.dd
Outdated
| --- | ||
|
|
||
| $(H4 Escape Sequences) | ||
| $(H4 $(LNAME2 escape-sequences, Escape Sequences)) |
Member
There was a problem hiding this comment.
Why dash here and underscore everywhere else?
wilzbach
force-pushed
the
add-labels-to-lex
branch
from
25a51c4 to
91357ac
Compare
wilzbach
force-pushed
the
add-labels-to-lex
branch
from
91357ac to
f287e06
Compare
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
Contributor
Author
It seems there's no standard and both dash and underscores are used in various spec pages, but underscores are used in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels are nice and necessary if you want to direct a reader to a specific place of the D spec.