Add pre-release version changelog to version list #1769
Conversation
|
Thanks for your pull request, @CyberShadow! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
I don't mind whether you use $2 or hard-code it into CHANGELOG_VERSION_PRE, but doing both seems a bit redundant ;-)
| CHANGELOG_VERSION_PRE = $(LI <a id="$1" href="$1_pre.html">$1</a><span class="hide-from-nav"> (not yet released)</span>) | ||
| _=BEGIN_GENERATED_CHANGELOG_VERSIONS | ||
| CHANGELOG_VERSIONS = | ||
| $(CHANGELOG_VERSION_PRE 2.075.0, not yet released) |
There was a problem hiding this comment.
"not yet released" is redundant here - you only use $1 in CHANGELOG_VERSION_PRE
There was a problem hiding this comment.
This part is generated by the script, so excluding _PRE from having its release date extracted would be more complicated.
I could make _PRE use $2 I guess.
CyberShadow
force-pushed
the
pull-20170625-094321
branch
from
bc42a7c to
ea6fd7f
Compare
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
LGTM, but I think we probably need to apply dlang/phobos#5505 to master as well or wait until dlang/phobos#5504 is in...
|
Would be good to build the changelog from the correct branch somehow, I guess. |
|
Yeah, but how would the script know that the "stable-branch-off" has
happened?
…On Mon, Jun 26, 2017, 12:22 Vladimir Panteleev ***@***.***> wrote:
Would be good to build the changelog from the correct branch somehow, I
guess.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1769 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AEKwdhHj1tJdpt2eaWKv_ez9jbbr2QWBks5sH4ZXgaJpZM4OEkCx>
.
|
wilzbach
force-pushed
the
pull-20170625-094321
branch
from
ea6fd7f to
dc129ff
Compare
|
(rebased to rekick DAutoTest as the changelog has been manually added now) |
wilzbach
left a comment
wilzbach
left a comment
There was a problem hiding this comment.
LGTM - thanks.
I am leaving the "how are we going to build the changelog during the branch-off question" to another day / issue / pull request. Maybe simply bumping the VERISON file at dlang.org works?
|
SIgh, what happened with the "not yet released" text on http://dlang.org/changelog/2.075.0_pre.html? @MartinNowak Could we please keep "not yet released" on that page up until the release actually occurring? We already had questions about it when someone found the page on Google what was up with the future release date. |
3 participants
Depends on (and includes) #1766 (due to an unavoidable merge conflict otherwise).