Merge remote-tracking branch 'upstream/stable' into merge_stable #10484

MartinNowak · 2019-10-16T09:14:17Z

No description provided.

dlang-bot · 2019-10-16T09:14:18Z

Thanks for your pull request, @MartinNowak!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	15069	regression	[REG2.064] nonsense struct template instantiations still compile
✓	19884	regression	[regression] Error: alias op = op; cannot alias itself, use a qualified name to create an overload set
✓	20092	critical	void[1] auto slicing makes the compiler hang
✓	20253	major	bad debug line info for function without epilog
✓	20264	critical	ICE on illegal cast to vector.
✓	20280	critical	Compiler segfault when building two small files
✓	20348	regression	[Reg 2.089.0-rc.1] Bad debug info for enum forward references
✓	20356	enhancement	exceeding template expansion limits
✓	20366	critical	CTFE foreach_reverse on array with utf characters crashes compiler
✓	20376	regression	@disable this(ref return scope Foo rhs) enables broken binaries (out-of-bounds access)
✓	20388	regression	Parse error when compiling lambdas in mixins as template parameters
✓	20420	regression	[REG2.067] inlining error with a valid function
✓	20431	minor	Allow a Mixin Type to resolve to an expression where it makes sense

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10484"

After Iain's cut-down in v2.089.

[stable] Cherry-pick C++ mangling regression fix from master

An assert failed in AssignExpr sema because the VectorExp created for a particular case of cast was not analysed and hence had not type. With the fix, and since the cast was illegal, a valid TypeError is now present.

fix issue 20264 - ICE on illegal cast to vector.

do not rewrite the length of the debug record, it is padded during allocation

* Raises the limit from 300 to 500 and gives clearer error msg. * make the test give the right error msg * moved the constant to globals.Global * changed some more constants * rename

Fix #20356 raises recursive expansion limit merged-on-behalf-of: Razvan Nitu <RazvanN7@users.noreply.github.com>

Index is not decremented which causes bounds checking error.

Fix issue 20366 - fix a programming bug in ctfe foreach_reverse code

…ken binaries (out-of-bounds access)

@disable

Issue 20376 - @disable this(ref return scope Foo rhs) enables broken binaries (out-of-bounds access)

[stable] Slightly re-extend the C++ interface for LDC

Fix issue 20388 - Parse mixin as an expression in template parameters

…elf, use a qualified name to create an overload set

fix issue 19884 - [regression] Error: alias op = op; cannot alias its… merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

fix issue 15069 - nonsense struct template instantiations still compile merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

fix issue 20092 - void[1] auto slicing makes the compiler hang merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

fix size of function by using the actual emitted code offset, not guessing from epilog data do not emit line number for closing brace if the epilog was omitted

Fix Issue 20280 - Compiler segfault when building two small files

The destructor expression for variable declaration is not scanned, as well as the arguments prefix for the new expression.

Fix issue 20420 - some expressions are missed during by the inliner merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

…ing reference in certain cases

fix Issue 20416 - [Regression 2.073.2] compiler complains about escap…

Fix issue 20431 - Allow a Mixin Type to resolve to an expression merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

fix Issue 20349 - [REG2.087] ICE with sqrt merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

CIRCLE_STAGE is either `pic` or `-no_pic`, not `build` or some other value.

Fix circle CI issue "MODEL: unbound variable"

fix Issue 20441 - Wrong code with -O -fPIC and pointer subtraction merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

WalterBright · 2019-12-21T06:54:57Z

Never mind that commit I did.

Slightly re-extend the C++ interface for LDC

234c83e

After Iain's cut-down in v2.089.

MartinNowak force-pushed the merge_stable branch from 764345b to 3ca9d9c Compare October 23, 2019 21:15

MartinNowak requested a review from ibuclaw as a code owner October 23, 2019 21:15

dlang-bot added the Enhancement label Oct 23, 2019

MartinNowak force-pushed the merge_stable branch from 3ca9d9c to fcb024a Compare October 27, 2019 13:30

ibuclaw and others added 3 commits November 1, 2019 23:07

dmd/cppmangle.d: Fix regression in ref substitution

9fa924f

bump VERSION to v2.089.0

ed9025c

purge changelog

9304dde

MartinNowak force-pushed the merge_stable branch from fcb024a to bc42063 Compare November 3, 2019 03:47

wilzbach and others added 20 commits November 3, 2019 11:43

Merge pull request dlang#10527 from kinke/ref

4a0fd6c

[stable] Cherry-pick C++ mangling regression fix from master

fix issue 20264 - ICE on illegal cast to vector.

db77b6c

An assert failed in AssignExpr sema because the VectorExp created for a particular case of cast was not analysed and hence had not type. With the fix, and since the cast was illegal, a valid TypeError is now present.

Merge pull request dlang#10532 from clYd3r/issue-20264

762a831

fix issue 20264 - ICE on illegal cast to vector.

fix issue 20348 - Bad debug info for enum forward reference

4b09b59

do not rewrite the length of the debug record, it is padded during allocation

Fix Issue 20356 raises recursive expansion limit

b4a814c

* Raises the limit from 300 to 500 and gives clearer error msg. * make the test give the right error msg * moved the constant to globals.Global * changed some more constants * rename

Merge pull request dlang#10538 from burner/expansionLimitRaise_20356

9ca8b27

Fix #20356 raises recursive expansion limit merged-on-behalf-of: Razvan Nitu <RazvanN7@users.noreply.github.com>

Fix issue 20366 - programming bug in ctfe foreach_rverse code

450c957

Index is not decremented which causes bounds checking error.

Merge pull request dlang#10547 from SSoulaimane/ctfeutfice

44cd826

Fix issue 20366 - fix a programming bug in ctfe foreach_reverse code

Fix Issue 20376 - @disable this(ref return scope Foo rhs) enables bro…

ab55186

…ken binaries (out-of-bounds access)

Merge pull request dlang#10558 from RazvanN7/Issue_20376

9348253

Issue 20376 - @disable this(ref return scope Foo rhs) enables broken binaries (out-of-bounds access)

Merge pull request dlang#10494 from kinke/ldc_cpp

47874e5

[stable] Slightly re-extend the C++ interface for LDC

fix issue 20092 - void[1] auto slicing makes the compiler hang

738b5ba

Fix issue 20388 - Parse mixin as an expression in template parameters

764e10c

Fix Issue 20280 - Compiler segfault when building two small files

4e373d7

Merge pull request dlang#10584 from BorisCarvajal/tparg_mixinexp

062952b

Fix issue 20388 - Parse mixin as an expression in template parameters

fix issue 19884 - [regression] Error: alias op = op; cannot alias its…

2bf46b6

…elf, use a qualified name to create an overload set

Merge pull request dlang#10599 from StianGulpen/issue-19884

23c7305

fix issue 19884 - [regression] Error: alias op = op; cannot alias its… merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

fix issue 15069 - nonsense struct template instantiations still compile

a7dbe96

Merge pull request dlang#10613 from StianGulpen/issue-15069

94e56d7

fix issue 15069 - nonsense struct template instantiations still compile merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

Merge pull request dlang#10571 from StianGulpen/issue-20092

b92dd0d

fix issue 20092 - void[1] auto slicing makes the compiler hang merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

rainers and others added 5 commits November 26, 2019 04:43

fix issue 20253 - bad debug line info for function without epilog (COFF)

c22090b

fix size of function by using the actual emitted code offset, not guessing from epilog data do not emit line number for closing brace if the epilog was omitted

Merge pull request dlang#10465 from RazvanN7/Issue_20280

da6fc42

Fix Issue 20280 - Compiler segfault when building two small files

Fix issue 20420 - some expressions are missed during by the inliner

c9e5c49

The destructor expression for variable declaration is not scanned, as well as the arguments prefix for the new expression.

Merge pull request dlang#10627 from SSoulaimane/f20420

0ab8b02

Fix issue 20420 - some expressions are missed during by the inliner merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

bump VERSION to v2.089.1-beta.1

feef16d

MartinNowak force-pushed the merge_stable branch from bc42063 to ed8390e Compare December 1, 2019 18:42

MartinNowak requested a review from WalterBright as a code owner December 1, 2019 18:42

BorisCarvajal and others added 12 commits December 5, 2019 08:37

Fix issue 20431 - Allow a Mixin Type to resolve to an expression

ece7f2c

fix Issue 20416 - [Regression 2.073.2] compiler complains about escap…

a1d82c6

…ing reference in certain cases

Merge pull request dlang#10640 from WalterBright/fix20416

9b0cd0d

fix Issue 20416 - [Regression 2.073.2] compiler complains about escap…

Merge pull request dlang#10629 from BorisCarvajal/typemixinexp

14f20c1

Fix issue 20431 - Allow a Mixin Type to resolve to an expression merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

fix Issue 20349 - [REG2.087] ICE with sqrt

294a257

Merge branch 'stable' into fix20349

afd9a41

Merge pull request dlang#10652 from WalterBright/fix20349

4538344

fix Issue 20349 - [REG2.087] ICE with sqrt merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

Fix circle CI issue "MODEL: unbound variable"

ea1d142

CIRCLE_STAGE is either `pic` or `-no_pic`, not `build` or some other value.

Merge pull request dlang#10662 from thewilsonator/fix-circle

cdf458a

Fix circle CI issue "MODEL: unbound variable"

fix Issue 20441 - Wrong code with -O -fPIC and pointer subtraction

a4bc86c

Merge pull request dlang#10661 from WalterBright/fix20441

a5d1cae

fix Issue 20441 - Wrong code with -O -fPIC and pointer subtraction merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>

bump VERSION to v2.089.1

a6a23d3

MartinNowak force-pushed the merge_stable branch from ed8390e to 903f517 Compare December 14, 2019 22:22

MartinNowak requested a review from RazvanN7 as a code owner December 14, 2019 22:22

MartinNowak force-pushed the merge_stable branch from 903f517 to 28022c7 Compare December 16, 2019 09:56

Merge remote-tracking branch 'upstream/stable' into merge_stable

053d700

MartinNowak force-pushed the merge_stable branch from 28022c7 to 053d700 Compare December 18, 2019 09:12

MartinNowak merged commit 403f336 into dlang:master Dec 20, 2019

MartinNowak deleted the merge_stable branch December 20, 2019 07:54

WalterBright pushed a commit to WalterBright/dmd that referenced this pull request Dec 21, 2019

Merge pull request dlang#10484 from MartinNowak/merge_stable

201c2da

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Merge remote-tracking branch 'upstream/stable' into merge_stable #10484

Merge remote-tracking branch 'upstream/stable' into merge_stable #10484

MartinNowak commented Oct 16, 2019

dlang-bot commented Oct 16, 2019 •

edited

WalterBright commented Dec 21, 2019

Merge remote-tracking branch 'upstream/stable' into merge_stable #10484

Merge remote-tracking branch 'upstream/stable' into merge_stable #10484

Conversation

MartinNowak commented Oct 16, 2019

dlang-bot commented Oct 16, 2019 • edited

Bugzilla references

Testing this PR locally

WalterBright commented Dec 21, 2019

dlang-bot commented Oct 16, 2019 •

edited