Skip to content

Add length property to cartesianProduct for finite forward ranges#10960

Closed
manavgupta26 wants to merge 1 commit intodlang:masterfrom
manavgupta26:fix-9871-cartesianProduct-length
Closed

Add length property to cartesianProduct for finite forward ranges#10960
manavgupta26 wants to merge 1 commit intodlang:masterfrom
manavgupta26:fix-9871-cartesianProduct-length

Conversation

@manavgupta26
Copy link
Contributor

Adds a length property to cartesianProduct when all input ranges
are finite forward ranges supporting length.

The length is computed as the product of the input ranges' lengths.

Fixes https://issues.dlang.org/show_bug.cgi?id=9871

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @manavgupta26! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10960"

Copy link
Contributor

@pbackus pbackus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please remove all changes to the indentation of existing code.
  2. 9871 is the Github issue number, not the issues.dlang.org number. Please change the relevant line in the commit PR description to Fixes issue 9871 .

@pbackus
Copy link
Contributor

pbackus commented Feb 21, 2026

Closing because the author has resubmitted in #10961.

@pbackus pbackus closed this Feb 21, 2026
@manavgupta26
Copy link
Contributor Author

manavgupta26 commented Feb 21, 2026 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants