made joiner.front assignable #4887
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakobOvrum
reviewed
Nov 3, 2016
|
|
||
| static if (hasAssignableElements!(ElementType!RoR)) | ||
| { | ||
| @property void front(ElementType!(ElementType!RoR) element) |
Contributor
Author
There was a problem hiding this comment.
Don't auto ref args need to be templated? It didn't compile when I tried it.
Contributor
There was a problem hiding this comment.
Maybe an overload in hasLvalueElements with a ref parameter would be appropriate?
Contributor
Author
|
I added a ref overload |
Contributor
Author
|
I improved the unittest |
Member
|
I think just making |
Contributor
Author
|
This PR is for the case that the sub range has hasAssignableElements but does not have hasLvalueElements. |
JackStouffer
approved these changes
Jan 18, 2017
Contributor
|
Auto-merge toggled on |
Contributor
|
@Superstar64 If reviewers go this long without commenting, please ping us! Sometimes things fall through the cracks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.