std.uri Cleanup

[JackStouffer]

• removed most global imports
• removed commented out code
• made some declarations private

[JackStouffer]

Ok, so apparently this broke something in the project tester, but I can't find anything that tells me why something broke.

[PetarKirov]

1. Click on Project Tester -> https://ci.dawg.eu/job/phobos_trigger/198/
2. Click on Subproject Builds: DPL Failed (e.g. #1013) -> https://ci.dawg.eu/job/DPL/1013/
3. Click on Subproject Builds projects Failed (e.g. #874) -> https://ci.dawg.eu/job/projects/874/
4. Look for red projects (in this case vibe.d) -> https://ci.dawg.eu/job/projects/874/REPO=rejectedsoftware%2Fvibe.d/
5. Go to Console Output (it's on the left) to see the output log and error messages -> https://ci.dawg.eu/job/projects/874/REPO=rejectedsoftware%2Fvibe.d/console
6. At the bottom you should see a segfault in one of vibe.d's tests, configuration libasync.

[JackStouffer]

Hmm, doesn't seem related.

[UplinkCoder]

You cannot just make things private.
This is begging for breakage.

[JackStouffer]

These are undocumented. The only way someone could be using these is if they read the source, in which case they should know better.

[wilzbach]

LGTM assuming CIs pass - I agree that undocumented methods can (and should) be set to private

[JackStouffer]

Auto-merge toggled on

[UplinkCoder]

@JackStouffer you just broke vibe.d.

[JackStouffer]

Are you sure? Vibe was failing to compile with some druntime pulls.

[UplinkCoder]

looks that way to me.
seemed to work before this pull.

[JackStouffer]

Can you post an error message?

[UplinkCoder]

@JackStouffer looks like you introduced an import cycle

[UplinkCoder]

it segfaults somewhere in libasync

[UplinkCoder]

could be that it is really unrelated.
But please pay more attention to these kinds of failiures.
@ZombineDev it looks like your annotations pr in druntime did something unintended.

[PetarKirov]

Yes, it's my fault. See https://issues.dlang.org/show_bug.cgi?id=17130.