Skip to content

std.container.Array - optimize concatenation#5295

Merged
dlang-bot merged 1 commit intodlang:masterfrom
byebye:array_cat_opts
Mar 23, 2017
Merged

std.container.Array - optimize concatenation#5295
dlang-bot merged 1 commit intodlang:masterfrom
byebye:array_cat_opts

Conversation

@byebye
Copy link
Contributor

@byebye byebye commented Mar 20, 2017

No description provided.

@JackStouffer
Copy link
Contributor

insertBack seems to already reserve space.

@byebye
Copy link
Contributor Author

byebye commented Mar 21, 2017

It does, but the previous version requires two allocations, whereas mine only one assuming the length is known.

Copy link
Member

@quickfur quickfur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants