Skip to content

Merge pull request #7328 from berni44/reg_numeric_customfloat#7331

Merged
atilaneves merged 1 commit into
stablefrom
unknown repository
Jan 2, 2020
Merged

Merge pull request #7328 from berni44/reg_numeric_customfloat#7331
atilaneves merged 1 commit into
stablefrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Dec 26, 2019

Fix unittest, which assumed real exponents having at least 15 bit.
merged-on-behalf-of: Nicholas Wilson thewilsonator@users.noreply.github.com

It's the first time I'm using cherry-pick, so I hope I got everything right. The original PR #7328 was merged on master, but should have been on stable. This PR is intended to fix this...

Fix unittest, which assumed real exponents having at least 15 bit.
merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
@ghost ghost requested a review from andralex as a code owner December 26, 2019 11:32
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @berni44! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + phobos#7331"

@ghost
Copy link
Copy Markdown
Author

ghost commented Dec 31, 2019

The problems in buildkite/phobos seem not to be related. Is it possible to restart this test?

Anyway, as this is a regression fix, which has allready been merged into master, I think, this should be merged rather soon to avoid a final stable release without it.

@ghost
Copy link
Copy Markdown
Author

ghost commented Jan 2, 2020

ping?

@atilaneves atilaneves merged commit 6561eb4 into dlang:stable Jan 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants