Fix to allow canvas paintings with a short canvas id to output iiif properties#528
Merged
JackLewis-digirati merged 2 commits intodevelopfrom Jan 13, 2026
Merged
Fix to allow canvas paintings with a short canvas id to output iiif properties#528JackLewis-digirati merged 2 commits intodevelopfrom
JackLewis-digirati merged 2 commits intodevelopfrom
Conversation
JackLewis-digirati
changed the title
donaldgray
approved these changes
Jan 13, 2026
…roperties - Allows fallback for canvas id - Adds in template options to the background handler - Additional logging
- Simplify log message - Extract method to simplify - Add new shared config class - Remove extraneous semicolon
JackLewis-digirati
force-pushed
the
fix/shortCanvasId
branch
from
0e40114 to
4c7e319
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #522
Resolves #526
Makes it so that short canvas id will correctly output IIIF properties by adding a fallback value
Note
This PR also fixes a masked issue around overrides not being correctly set in the background handler, and adds some additional logging