Various improvements#42
Merged
Merged
Conversation
Move endpoint definitions out of Program.cs into dedicated feature classes for both Builder and Search APIs, following a vertical slice structure.
- Add generic base class with common IsEnabledAsync guard - Move empty-query short-circuit and GetTextAsync + Search call to base - SearchHandler and SearchV2Handler now only implement BuildResponse Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Replace UseInMemoryDatabase with a real postgres:16-alpine container managed by Testcontainers. EF migrations are applied once at collection fixture initialisation, giving tests a schema that matches production. Hangfire remains on InMemory as it is not the subject of this change. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
* No need to remove registered services when using ConfigureTestServices * Fixed issue with captured local-var requiring hoop jumping to get TestContainers working for tests
All three Program.cs files now use Configure<T>(section) instead of resolving the options POCO eagerly and registering it as a singleton. Handlers, services, and endpoint lambdas inject IOptions<T> and access .Value. Tests wrap inline constructions with Options.Create(). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keeps Program.cs focused on composition; Hangfire-specific wiring lives in HangfireServiceCollectionExtensions.AddHangfireServices. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.claude/settings.local.json