RULES: Unnecessary template rule removed, md table made yaml #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anuunchin
force-pushed
the
rules/replace-md-tables
branch
from
142e5b9 to
d394a31
Compare
anuunchin
force-pushed
the
rules/replace-md-tables
branch
from
d394a31 to
80fb048
Compare
anuunchin
commented
Aug 26, 2025
| | Data Array Path | `data`, `results`, `items`, `records`, `entries` | `endpoint.data_selector`| JSON path to the list of items | | ||
| ```yaml | ||
| client: | ||
| base_url: |
Collaborator
Author
There was a problem hiding this comment.
@zilto
maybe there should be another field concept_name:
so that we have something like
client:
base_url:
concept_name: "Base URL"
common_api_terms: ["Base URL", "API Endpoint", "Root URL", "Service URL"]Otherwise, the names look like strictly defined variables 👀
Collaborator
There was a problem hiding this comment.
I think it's fine given base_url is described via multiple common_api_terms
zilto
approved these changes
Aug 26, 2025
Collaborator
zilto
left a comment
zilto
left a comment
There was a problem hiding this comment.
I think it's a net improvement. Approved!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the unnecessary template
rule.mdand converts the markdown table inrest_api_extract_parameters.mdto YAML format.Resolves #633