11783 concrete design addon by david-liska · Pull Request #86 · dlubal-software/Dlubal_JavaScript_Library

david-liska · 2023-06-05T10:52:30Z

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Unit Tests
Attached examples
Own example attached to Pull Request

Test Configuration:

RFEM / RSTAB / RSECTION version:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

API support is missing.

API is missing

jarabroz · 2023-06-06T10:33:22Z

+    reinforcementDirection.SetDirectionRotations(Math.PI / 4, Math.PI / 2);
+
+    /**************************************************** Types for concrete design - Surface reinforcement ****************************************************/
+    var reinforcementMaterial = new Material(undefined, "Grade 40");


Grade 40 is not EC material for reinforcement - use switch based on Code standard

It seems you fixed it?

jarabroz · 2023-06-06T10:36:22Z

+run("../includes/Tools/clearAll.js");
+
+var material = new Material(undefined, "C12/15");
+var section = new Section(undefined, "IPE 80", material.GetNo());


? It needs to be a concrete beam

It seems you fixed it?

jarabroz · 2023-06-06T10:50:51Z

It could be better to split file into several files - each demo for standard. Then we do not need to deal with switches and selections of standard.
It could be easier also for Automated testing.

Steel design is based on this idea too and finished AT is design with this way (there is only problem with time, for one test slightly exceeds 1 minute - concrete design example has less standards). We can discuss about it.

jarabroz · 2023-06-22T13:37:09Z

@@ -0,0 +1,34 @@
+/*
+NO API support?


jarabroz · 2023-06-22T13:37:53Z

@@ -0,0 +1,34 @@
+/*
+NO API support?
+*/


If there is not support in JS and perhaps released why to create this?

It remains to process fixed bugs.

Need to prevent of duplicity

pull-request-quantifier-deprecated · 2023-08-17T12:19:01Z

This PR has 5541 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +5473 -68
Percentile : 100%

Total files changed: 23

Change summary by file extension:
.ps1 : +1 -1
.js : +5466 -67
.xml : +6 -0

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detected.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

david-liska added 21 commits April 17, 2023 11:05

Backup

58429d7

Strength configuration for ACi standard

a8cef0b

Ultimate configuration - CSA standard

def6805

Ultimate configuration - NTC standard

d8d5971

API support is missing.

Punching for EN standard

b22aa92

Punching - all other code standards

d69b226

Serviceability configuration (EN, ACI)

8937b75

Serviceability configuration (CSA)

89ee0b2

Serviceability configuration (SP)

e7bdec1

Serviceability configuration (NTC)

af65277

API is missing

Examples fix

4ea25ac

Backup

82d93fb

Effective length

8b94471

Concrete durabilities

3df7c29

Reinforcement direction

cfb8842

Surface reinforcement

bc71d5b

Punching reinforcement

073dc77

Concrete design - surface support

4fe7c61

Before code review

b45fc6e

Better support for RSTAB

06b0c24

Before code review

db519ce

david-liska requested a review from jarabroz as a code owner June 5, 2023 10:52

pull-request-quantifier-deprecated Bot added the Extra Large label Jun 5, 2023

jarabroz reviewed Jun 6, 2023

View reviewed changes

Comment thread includes/GuideObjects/CoordinateSystem.js Outdated

Build fix

03fb376

jarabroz suggested changes Jun 7, 2023

View reviewed changes

jarabroz added 2 commits June 20, 2023 08:29

Merge branch 'main' into 11783-Concrete_design_addon

9c0d077

Fixed issue from merge

d28326c

jarabroz reviewed Jun 22, 2023

View reviewed changes

Comment thread includes/AddOns/ConcreteDesign/ConcreteDesignSupport.js Outdated

jarabroz reviewed Jun 22, 2023

View reviewed changes

jarabroz suggested changes Jun 22, 2023

View reviewed changes

jarabroz suggested changes Jun 23, 2023

View reviewed changes

Comment thread includes/AddOns/ConcreteDesign/UltimateConfigurationNTC.js Outdated

Comment thread includes/AddOns/ConcreteDesign/UltimateConfigurationEN.js Outdated

david-liska added 8 commits July 7, 2023 15:43

After code review

6440eb4

It remains to process fixed bugs.

Code review fixes

1daec63

Unbraced structure type for SP standard

622eccb

Renamed functions

94957b8

Need to prevent of duplicity

Update

3c7ab23

Update SurfaceReinforcement.js

7e2fb81

Update

9a82ce9

Backup

a4a033e

jarabroz approved these changes Aug 18, 2023

View reviewed changes

jarabroz self-requested a review August 18, 2023 09:06

jarabroz approved these changes Aug 18, 2023

View reviewed changes

jarabroz merged commit f1b4ebe into main Aug 18, 2023

jarabroz deleted the 11783-Concrete_design_addon branch August 18, 2023 09:11

Conversation

david-liska commented Jun 5, 2023

Description

Type of change

How Has This Been Tested?

Checklist:

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jarabroz Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

david-liska Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

jarabroz Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

david-liska Jul 7, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jarabroz Jun 6, 2023

Choose a reason for hiding this comment

Uh oh!

david-liska Jul 7, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jarabroz Jun 22, 2023

Choose a reason for hiding this comment

Uh oh!

jarabroz Jun 22, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

pull-request-quantifier-deprecated Bot commented Aug 17, 2023

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

david-liska Jul 7, 2023 •

edited

Loading