Ondrej Michal: static method decorators #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
March 18, 2022 14:22
+ some fixes along the way test results: 119 passed, 10 skipped in 127.53s (0:02:07)
uncommented few working tests removed few comments unit tests: 119 passed, 10 skipped in 132.23s
Control points, weights and order is taken semi-automatically from nodes with order 3 and 3 nodes.
unit tests: 119 passed, 10 skipped in 131.81s examples: all passed
added 4 commits
March 25, 2022 09:15
…static_method_decorators unit tests: 121 passed, 10 skipped in 150.13s
…static_method_decorators
dogukankaratas
approved these changes
Mar 25, 2022
added 2 commits
March 28, 2022 07:02
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves issue #107.
The aim was to remove all default dictionaries for 'params' variable, add @staticmethod decorator where 'self' is not needed. Remove 'self' from method definition where redundant and make some enhancements while in there.
Please run all unit tests and examples (UnitTests\Examples.py) on current GM to verify everything is running properly.
We should also use this major refurbishment to create new release version. Tag R-v1.1.0 added.