-
Notifications
You must be signed in to change notification settings - Fork 35
Ondrej Michal-special objects update #135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
initial commit
unit tests: 147 passed, 9 skipped in 199.99s
dogukankaratas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a bug for result section in core operations most probably.
UnitTests/test_SpecialObjects.py
Outdated
|
|
||
| SurfaceContact(1, 1, '1', '3') | ||
|
|
||
| ResultSection(1,ResultSectionType.TYPE_2_POINTS_AND_VECTOR, ResultSectionResultDirection.SHOW_RESULTS_IN_GLOBAL_MINUS_X,True,[1, [1,0,0], [0,2,0], ResultSectionProjection.PROJECTION_IN_VECTOR, [1,1,1]],) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be caused by assigned_to_surfaces and assigned_to_solids. Before both True, now True False. Assert doesn't show.
…special_objects_update
tested on latest GM unit tests: 147 passed, 9 skipped in 169.79s
|
This PR has Quantification details
Why proper sizing of changes matters
Optimal pull request sizes drive a better predictable PR flow as they strike a
What can I do to optimize my changes
How to interpret the change counts in git diff output
Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email) |

Updated Intersections, Surface Results Adjustments, Surface Contacts, Result Sections, and Structure Modifications.
Test created.
unit tests: 147 passed, 9 skipped in 199.99s