Concrete Design Input Data

[dogukankaratas]

• Concrete Design folder created
• Types for Concrete Design folder created
• Test file added under UT folder

[OndraMichal]

Hi,
please take into account, that all numbers of lines are +1 due to "#pylint: disable=" at the beginning, when I tested it.

************* Module ConcreteServiceabilityConfigurations
ConcreteServiceabilityConfigurations.py:15:34: C0303: Trailing whitespace (trailing-whitespace)
ConcreteServiceabilityConfigurations.py:29:0: C0303: Trailing whitespace (trailing-whitespace)
ConcreteServiceabilityConfigurations.py:54:0: C0303: Trailing whitespace (trailing-whitespace)
ConcreteServiceabilityConfigurations.py:65:46: C0303: Trailing whitespace (trailing-whitespace)
ConcreteServiceabilityConfigurations.py:66:0: C0304: Final newline missing (missing-final-newline)

************* Module ConcreteUltimateConfigurations
ConcreteUltimateConfigurations.py:15:34: C0303: Trailing whitespace (trailing-whitespace)
ConcreteUltimateConfigurations.py:29:0: C0303: Trailing whitespace (trailing-whitespace)
ConcreteUltimateConfigurations.py:54:0: C0303: Trailing whitespace (trailing-whitespace)
ConcreteUltimateConfigurations.py:65:46: C0303: Trailing whitespace (trailing-whitespace)
ConcreteUltimateConfigurations.py:66:0: C0304: Final newline missing (missing-final-newline)

************* Module TypesforConcreteDesign.ConcreteDurability
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:9:28: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:22:34: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:27:41: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:31:92: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:42:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:83:0: W0311: Bad indentation. Found 13 spaces, expected 16 (bad-indentation)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:84:0: W0311: Bad indentation. Found 17 spaces, expected 20 (bad-indentation)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:85:0: W0311: Bad indentation. Found 13 spaces, expected 16 (bad-indentation)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:86:0: W0311: Bad indentation. Found 17 spaces, expected 20 (bad-indentation)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:94:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:146:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:191:46: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:198:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:199:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:10:16: W0621: Redefining name 'name' from outer scope (line 2) (redefined-outer-name)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:71:11: C0121: Comparison to True should be just 'expr' (singleton-comparison)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:75:15: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:80:11: C0121: Comparison to True should be just 'expr' (singleton-comparison)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:83:13: R1720: Unnecessary "else" after "raise" (no-else-raise)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:83:16: C0121: Comparison to True should be just 'expr' (singleton-comparison)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:97:15: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:117:19: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:132:11: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:137:11: C0121: Comparison to False should be 'not expr' (singleton-comparison)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:150:11: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:155:11: C0121: Comparison to False should be 'not expr' (singleton-comparison)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:171:15: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteDurability.py:2:0: W0611: Unused name imported from os (unused-import)

************* Module TypesforConcreteDesign.ConcreteEffectiveLength
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:9:28: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:16:96: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:17:92: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:18:104: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:20:96: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:21:92: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:24:34: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:28:42: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:29:41: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:39:94: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:40:69: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:41:97: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:46:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:66:27: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:94:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:95:24: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:114:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:122:46: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:129:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:130:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:10:16: W0621: Redefining name 'name' from outer scope (line 2) (redefined-outer-name)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:70:11: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:78:11: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:88:8: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:97:8: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteEffectiveLength.py:2:0: W0611: Unused name imported from os (unused-import)

************* Module TypesforConcreteDesign.ConcreteReinforcementDirections
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteReinforcementDirections.py:9:28: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteReinforcementDirections.py:14:34: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteReinforcementDirections.py:21:84: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteReinforcementDirections.py:49:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteReinforcementDirections.py:57:46: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteReinforcementDirections.py:64:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteReinforcementDirections.py:65:0: C0303: Trailing whitespace (trailing-whitespace)

************* Module TypesforConcreteDesign.ConcreteSurfaceReinforcements
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:9:28: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:17:139: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:21:34: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:39:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:47:87: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:98:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:159:64: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:168:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:183:46: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:190:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:191:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:81:15: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:86:15: C0121: Comparison to False should be 'not expr' (singleton-comparison)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:100:11: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:100:45: C0123: Using type() instead of isinstance() for a typecheck. (unidiomatic-typecheck)
D:\Sources\RFEM_Python_Client_5\RFEM\TypesforConcreteDesign\ConcreteSurfaceReinforcements.py:161:12: C0200: Consider using enumerate instead of iterating with range and len (consider-using-enumerate)

************* Module enums
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:105:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:202:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:317:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:323:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:618:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:642:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:644:0: C0303: Trailing whitespace (trailing-whitespace)
The following issues in enums.py are fixed in main branch.
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:311:0: E0102: class already defined line 113 (function-redefined)
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:318:0: E0102: class already defined line 122 (function-redefined)
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:710:0: E0102: class already defined line 619 (function-redefined)
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:716:0: E0102: class already defined line 625 (function-redefined)
D:\Sources\RFEM_Python_Client_5\RFEM\enums.py:722:0: E0102: class already defined line 631 (function-redefined)

************* Module test_concreteDesign
D:\Sources\RFEM_Python_Client_5\UnitTests\test_concreteDesign.py:33:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\UnitTests\test_concreteDesign.py:60:32: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\UnitTests\test_concreteDesign.py:78:0: C0303: Trailing whitespace (trailing-whitespace)
D:\Sources\RFEM_Python_Client_5\UnitTests\test_concreteDesign.py:80:0: C0304: Final newline missing (missing-final-newline)
Superfluous empty lines line 33 through 52 in comparison to the rest of the file.

Just to let you know, there is a assert showing only when opening empty RFEM and running UnitTests\test_concreteDesign.py. This is the only scenario I was able to replicate it. I assume this is on WS (Igor of Jiri).

[pull-request-quantifier-deprecated]

This PR has 775 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

---

Quantification details

Label      : Extra Large
Size       : +763 -12
Percentile : 92.5%

Total files changed: 12

Change summary by file extension:
.py : +763 -12

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

• Fast and predictable releases to production:
  • Optimal size changes are more likely to be reviewed faster with fewer
    iterations.
  • Similarity in low PR complexity drives similar review times.
• Review quality is likely higher as complexity is lower:
  • Bugs are more likely to be detected.
  • Code inconsistencies are more likely to be detetcted.
• Knowledge sharing is improved within the participants:
  • Small portions can be assimilated better.
• Better engineering practices are exercised:
  • Solving big problems by dividing them in well contained, smaller problems.
  • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

• Use the PullRequestQuantifier to quantify your PR accurately
  • Create a context profile for your repo using the context generator
  • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
  • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
  • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
• Change your engineering behaviors
  • For PRs that fall outside of the desired spectrum, review the details and check if:
    • Your PR could be split in smaller, self-contained PRs instead
    • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

• One line was added: +1 -0
• One line was deleted: +0 -1
• One line was modified: +1 -1 (git diff doesn't know about modified, it will
  interpret that line like one addition plus one deletion)
• Change percentiles: Change characteristics (addition, deletion, modification)
  of this PR in relation to all other PRs within the repository.

---

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.