Ondrej Michal Add options to dialog #71

OndraMichal · 2021-11-05T06:11:48Z

US-8506: Web Services: Python: Improvement in initialization of connection with RFEM6

Description:
Purpose of this task is to add new options to input dialogue to enable use already existing models in RFEM or create new one. Edit name of the new model. If existing one is selected then enable deleting results and reset of the model. This envolves changes in initModle.py file to enable loading of existing models befor showing dialogue and then effective use of clientModel ( by creating Model class).

to create model or use existing one, to delete results, and to reset model. Added Model class to initModel to be able to first load models from RFEM and then offer them in dialogue. clientModel is now class variable of Model class.

dogukankaratas · 2021-11-08T12:22:22Z

Examples/Cantilever/Demo1.py

 if __name__ == '__main__':
    l = float(input('Length of the cantilever in m: '))
    f = float(input('Force in kN: '))



Adding Model class definition
Model(model_name='Demo1')

dogukankaratas · 2021-11-08T12:28:33Z

Examples/CantileverQt/Main.py

            input('Press Enter to exit...')
            sys.exit()

        # RFEM 6


Adding Model class definition
Model(model_name='Cantilever')

dogukankaratas · 2021-11-08T12:29:07Z

Examples/DesignSituations_Test.py

 from RFEM.LoadCasesAndCombinations.designSituation import *

 if __name__ == '__main__':



Adding Model Class definition
Model(model_name='DesignSituations_Test')

corrected.
Error: Invalid design situation type.' still persist. Out of the scope of this code review.

Björn is taking care of that error. @Bjoern-Steinhagen

dogukankaratas · 2021-11-08T12:30:07Z

Examples/Free_Load_Test.py

 if __name__ == '__main__':
-    clientModel.service.begin_modification('new')
+    Model.clientModel.service.begin_modification('new')



Adding Model Class definition
Model(model_name='FreeLoad_test')

dogukankaratas · 2021-11-08T12:31:33Z

Examples/GlobalParameters_Test.py

 from RFEM.initModel import *

 if __name__ == '__main__':



Adding Model Class definition
Model(model_name = 'GlobalParameters_test'

solved
suds.WebFault: Server raised fault: 'Enumeration item 'DEFINITION_TYPE_OPTIMIZATION' not found.' still persist.

dogukankaratas · 2021-11-08T12:50:38Z

RFEM/BasicObjects/material.py

+from RFEM.initModel import clearAtributes, Model

-class Material():
+class Material(Model):


No need to inherit Model class. Importing is enough.

inheritance removed

dogukankaratas · 2021-11-08T12:57:12Z

RFEM/initModel.py

-clientModel = cModel
+class Model():
+    clientModel = None
+    def __init__(self,


Some arguments are not using by the function and should be removed. Also adding defaults values could be useful.

dogukankaratas · 2021-11-08T12:59:37Z

RFEM/initModel.py

+                cModel.service.reset()
+
+        Model.clientModel = cModel
+        print('Geometry...')


print("Ready!") looks better than print('Geometry...'). Should we discuss it?

Well we can print what ever we agree on. By this messages I wanted to comunicate to user, which part of script is running. If Ready seems more appropriate, we can change it. Maybe we should vote on things like that. There is no 100% correct solution.

dogukankaratas · 2021-11-08T13:04:48Z

UnitTests/test_basicObjects.py



 def test_material():



Model(model_name = 'basicobjects_test')

dogukankaratas · 2021-11-08T13:05:35Z

main.py

-    clientModel.service.begin_modification('new')
-    print('Geometry...')
-
+    Model(hall_width_L, hall_height_h_o, hall_height_h_m, number_frames, frame_spacing, new_model, model_name, delete, reset)


Acc. to previous suggestions, line 28 should be change as;

Model(new_model, model_name, delete, reset)

pull request #71

dogukankaratas

Conflicts should be solven.

pull-request-quantifier-deprecated · 2021-12-01T13:24:36Z

This PR has 1250 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Extra Large
Size       : +661 -589
Percentile : 100%

Total files changed: 82

Change summary by file extension:
.py : +661 -589

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detetcted.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

MichalO added 2 commits November 2, 2021 08:44

Added options:

5e05045

to create model or use existing one, to delete results, and to reset model. Added Model class to initModel to be able to first load models from RFEM and then offer them in dialogue. clientModel is now class variable of Model class.

deleted commented lines

2d5a953

OndraMichal added the Large label Nov 5, 2021

OndraMichal requested a review from dogukankaratas November 5, 2021 06:11

OndraMichal assigned dogukankaratas Nov 5, 2021

pull-request-quantifier-deprecated bot added Extra Large and removed Large labels Nov 5, 2021

jarabroz enabled auto-merge November 5, 2021 10:06

dogukankaratas suggested changes Nov 8, 2021

View reviewed changes

code review corrections

518eab9

pull request #71

dogukankaratas approved these changes Nov 16, 2021

View reviewed changes

jarabroz disabled auto-merge December 1, 2021 12:29

jarabroz added 4 commits December 1, 2021 13:39

Merge branch 'main' into OndrejMichal-AddOptionsToDialog

bed11f1

Indentation fix

22a8028

Fix of Model in staticAnalysisSetting object

a1ff180

main Hall fix

2333a0f

jarabroz merged commit a5663f0 into main Dec 1, 2021

jarabroz deleted the OndrejMichal-AddOptionsToDialog branch December 1, 2021 13:45

		from RFEM.LoadCasesAndCombinations.designSituation import *

		if __name__ == '__main__':

Ondrej Michal Add options to dialog #71

Ondrej Michal Add options to dialog #71

Uh oh!

Conversation

OndraMichal commented Nov 5, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dogukankaratas left a comment

Choose a reason for hiding this comment

Uh oh!

pull-request-quantifier-deprecated bot commented Dec 1, 2021

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants